From owner-svn-src-head@freebsd.org  Tue May 29 13:45:33 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9C7D6F7DCED;
 Tue, 29 May 2018 13:45:33 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [88.99.82.50])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3B79E6B255;
 Tue, 29 May 2018 13:45:33 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from hps2016.home.selasky.org (unknown [62.141.128.70])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 8B8582603AE;
 Tue, 29 May 2018 15:45:31 +0200 (CEST)
Subject: Re: svn commit: r334320 - in head/sys: cddl/compat/opensolaris/kern
 cddl/compat/opensolaris/sys i386/include
From: Hans Petter Selasky <hps@selasky.org>
To: Cy Schubert <Cy.Schubert@cschubert.com>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
References: <201805291302.w4TD2bR5059884@slippy.cwsent.com>
 <168f4cd3-07d2-15cb-9cf4-a2d02f6dc260@selasky.org>
Message-ID: <ef2f383e-f95b-bf6e-c584-d98ea78ec380@selasky.org>
Date: Tue, 29 May 2018 15:45:18 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <168f4cd3-07d2-15cb-9cf4-a2d02f6dc260@selasky.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 May 2018 13:45:33 -0000

On 05/29/18 15:10, Hans Petter Selasky wrote:
>> Hi Hans,
>>
>> This broke in lib32 on an amd64 system.
>>
>> --- cddl/lib/libnvpair__L ---
>> In file included from /opt/src/svn-current/sys/cddl/contrib/opensolaris/
>> common/nvpair/opensolaris_fnvpair.c:29:
>> In file included from /opt/src/svn-current/cddl/contrib/opensolaris/lib/
>> libzpool/common/sys/zfs_context.h:74:
>> /opt/src/svn-current/sys/cddl/compat/opensolaris/sys/atomic.h:94:2:
>> error: implicit declaration of function 'atomic_subtract_64' is invalid
>> in C99 [-Werror,-Wimplicit-function-declaration]
>>          atomic_subtract_64(target, 1);
>>          ^
> 
> I only tested buildkernel i386 LINT + GENERIC with this change. I will 
> have a look ASAP.
> 
> --HPS

See r334328 .

--HPS