From owner-p4-projects@FreeBSD.ORG Tue Sep 25 12:07:33 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 76EAA16A468; Tue, 25 Sep 2007 12:07:33 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D82E16A419; Tue, 25 Sep 2007 12:07:33 +0000 (UTC) (envelope-from olli@fromme.com) Received: from haluter.fromme.com (haluter.fromme.com [83.120.8.11]) by mx1.freebsd.org (Postfix) with ESMTP id B05F813C461; Tue, 25 Sep 2007 12:07:32 +0000 (UTC) (envelope-from olli@fromme.com) Received: from haluter.fromme.com (irc_sucks@localhost [127.0.0.1]) by haluter.fromme.com (8.13.4/8.13.4) with ESMTP id l8PBWqLq040703; Tue, 25 Sep 2007 13:32:52 +0200 (CEST) (envelope-from olli@fromme.com) Received: (from olli@localhost) by haluter.fromme.com (8.13.4/8.12.9/Submit) id l8PBWhli040690; Tue, 25 Sep 2007 13:32:43 +0200 (CEST) From: Oliver Fromme Message-Id: <200709251132.l8PBWhli040690@haluter.fromme.com> To: cnst@freebsd.org (Constantine A. Murenin) Date: Tue, 25 Sep 2007 13:32:42 +0200 (CEST) In-Reply-To: <46F7FBC1.7080300@FreeBSD.org> from "Constantine A. Murenin" at Sep 24, 2007 02:02:41 PM X-Mailer: ELM [version 2.5 PL6] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.1.2 (haluter.fromme.com [127.0.0.1]); Tue, 25 Sep 2007 13:32:52 +0200 (CEST) Cc: "Constantine A. Murenin" , Perforce Change Reviews , Hans Petter Selasky , ticso@cicely.de Subject: Re: PERFORCE change 126745 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2007 12:07:33 -0000 Constantine A. Murenin wrote: > Hans Petter Selasky wrote: > > Some things I have in mind: > > > > Automatic __FBSDID() at top of C-files. > > > > Automatic "static prototypes". > > > > Automatic comments before every C-function is defined. > > > > Automatic use of typedefs when declaring certain device method functions: > > > > static device_attach_t my_attach; > > > > Automatically reorder the code so that it follows generic device driver > > layout. > > Automatic renaming of function names like hid_get_descriptor_from_usb() > and usbreq_get_report_descriptor() into something less wordy. FWIW, I like those functions names. As far as I can tell, they do not violate style(9), and I can't think of a good reason why verbose names should be forbidden. Especially when I have to read parts of the kernel code which I'm not familiar with (happens sometimes), I really apreciate it if the name of a function clearly indicates what the function does, without having to wade through anouther screenful of unknown code ... Best regards Oliver -- Oliver Fromme, Bunsenstr. 13, 81735 Muenchen, Germany ``We are all but compressed light'' (Albert Einstein)