From owner-freebsd-current@FreeBSD.ORG Thu Apr 13 14:46:53 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8DD7B16A400; Thu, 13 Apr 2006 14:46:53 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id C6E2943D4C; Thu, 13 Apr 2006 14:46:50 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k3DEkjZE037507; Thu, 13 Apr 2006 10:46:46 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: David Xu Date: Thu, 13 Apr 2006 10:46:25 -0400 User-Agent: KMail/1.9.1 References: <200604121103.32647.jhb@freebsd.org> <200604130907.51163.davidxu@freebsd.org> In-Reply-To: <200604130907.51163.davidxu@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200604131046.27204.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1396/Thu Apr 13 01:39:53 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: Csaba Henk , freebsd-current@freebsd.org Subject: Re: panic: Assertion !(curthread->td_flags & TDF_SINTR) failed X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Apr 2006 14:46:53 -0000 On Wednesday 12 April 2006 21:07, David Xu wrote: > On Wednesday 12 April 2006 23:03, John Baldwin wrote: > > On Wednesday 12 April 2006 09:52, Csaba Henk wrote: > > > Hi! > > > > > > With my CURRENT installation from Apr 1, I get: > > > > > > panic: Assertion !(curthread->td_flags & TDF_SINTR) failed at > > > /usr/src/sys/kern/subr_sleepqueue.c:529 cpuid = 0 > > > KDB: enter: panic > > > > The sleepq_remove() in msleep() to handle this nested sleep case isn't > > clearing the TDF_SINTR from the previous tsleep. I suspect this changed > > in the recent fixes as I think they changed the sleepqueue code to clear > > TDF_SINTR when the thread resumed, rather than clearing it when the thread > > was removed from the queue IIRC. > > > Can you test following patch ? I think the TDF_SINTR was never cleared in > sleepq_remove or sleepq_resume_thread, the functions were not touched in > my previous fixes.:-) Ah, ok. :) Odd that we didn't run into this until now. Patch looks ok to me. > David Xu > > > Index: subr_sleepqueue.c > =================================================================== > RCS file: /home/ncvs/src/sys/kern/subr_sleepqueue.c,v > retrieving revision 1.26 > diff -u -r1.26 subr_sleepqueue.c > --- subr_sleepqueue.c 23 Feb 2006 03:42:17 -0000 1.26 > +++ subr_sleepqueue.c 13 Apr 2006 00:59:01 -0000 > @@ -633,6 +633,7 @@ > > td->td_wmesg = NULL; > td->td_wchan = NULL; > + td->td_flags &= ~TDF_SINTR; > > /* > * Note that thread td might not be sleeping if it is running > -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org