From owner-freebsd-arm@FreeBSD.ORG Sun Aug 19 23:04:57 2012 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8F0EA106566C; Sun, 19 Aug 2012 23:04:57 +0000 (UTC) (envelope-from tim@kientzle.com) Received: from monday.kientzle.com (99-115-135-74.uvs.sntcca.sbcglobal.net [99.115.135.74]) by mx1.freebsd.org (Postfix) with ESMTP id 64F708FC08; Sun, 19 Aug 2012 23:04:57 +0000 (UTC) Received: (from root@localhost) by monday.kientzle.com (8.14.4/8.14.4) id q7JN4tGV046266; Sun, 19 Aug 2012 23:04:55 GMT (envelope-from tim@kientzle.com) Received: from [192.168.2.143] (CiscoE3000 [192.168.1.65]) by kientzle.com with SMTP id k8j5ngyxbz43uag8ayyma6vwy2; Sun, 19 Aug 2012 23:04:54 +0000 (UTC) (envelope-from tim@kientzle.com) Mime-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset=us-ascii From: Tim Kientzle In-Reply-To: <7E6C76BE-1D3F-40E4-BFE3-DC88715C234C@bsdimp.com> Date: Sun, 19 Aug 2012 16:04:53 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <12A967D8-BC49-49AF-BBD9-40E259932617@kientzle.com> References: <20120819.171723.523519054460575158.hrs@allbsd.org> <8CDAB51C-14A0-42F0-8E16-43A3EABA2703@bsdimp.com> <7E6C76BE-1D3F-40E4-BFE3-DC88715C234C@bsdimp.com> To: Warner Losh X-Mailer: Apple Mail (2.1278) Cc: gonzo@freebsd.org, freebsd-arm@freebsd.org Subject: Re: gpiobus_hinted_child >32 pins support, pin_getname method, and gpio-sysctl bridge patch X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2012 23:04:57 -0000 On Aug 19, 2012, at 10:02 AM, Warner Losh wrote: >=20 > On Aug 19, 2012, at 10:03 AM, Tim Kientzle wrote: >=20 >> On Aug 19, 2012, at 8:38 AM, Warner Losh wrote: >>=20 >>>=20 >>> In general, I like this code in the context of the current GPIO = framework. I've been growing dissatisfied with the current GPIO = framework, however, and some of my comments reflect that more than any = comments about this specific code. >>=20 >> I noticed that Linux on BeagleBone does not >> simply number all pins as we do. Pins are identified by >> two numbers: a unit number and a pin number. >=20 > Is this in the code, or just in the FTD? On Atmel, there's a single = number from 0 to max-1 with all negative numbers being invalid. But = Atmel doesn't have proper FTD support in Linux just yet (3.5 has a good = start, and 3.6 will add the missing pinmux/pinctl stuff). I'm not exactly sure what you mean. The Linux DTS file: = http://git.kernel.org/?p=3Dlinux/kernel/git/torvalds/linux.git;a=3Dblob;f=3D= arch/arm/boot/dts/am335x-bone.dts inherits most of the real functionality from = http://git.kernel.org/?p=3Dlinux/kernel/git/torvalds/linux.git;a=3Dblob;f=3D= arch/arm/boot/dts/am33xx.dtsi There are certainly separate entries there for each GPIO module. I = presume (but haven't verified) that the unit number maps directly to a = "gpio#" device name. Tim