From owner-freebsd-stable@FreeBSD.ORG Mon Apr 28 21:35:06 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 44856106564A for ; Mon, 28 Apr 2008 21:35:06 +0000 (UTC) (envelope-from cokane@cokane.org) Received: from QMTA10.westchester.pa.mail.comcast.net (qmta10.westchester.pa.mail.comcast.net [76.96.62.17]) by mx1.freebsd.org (Postfix) with ESMTP id D923C8FC1C for ; Mon, 28 Apr 2008 21:35:05 +0000 (UTC) (envelope-from cokane@cokane.org) Received: from OMTA09.westchester.pa.mail.comcast.net ([76.96.62.20]) by QMTA10.westchester.pa.mail.comcast.net with comcast id Jy9y1Z0030SCNGk5A0rW00; Mon, 28 Apr 2008 21:17:47 +0000 Received: from discordia ([24.60.135.75]) by OMTA09.westchester.pa.mail.comcast.net with comcast id K9Ji1Z00B1dmTCQ3V00000; Mon, 28 Apr 2008 21:18:43 +0000 X-Authority-Analysis: v=1.0 c=1 a=SxMJ7Ujbdh8A:10 a=F_MVhViW1LYA:10 a=EdUaHDTlrWCWWoVTl24A:9 a=xHHvmBeIMp-kAVDvSJgA:7 a=DsjNcM5imHvZ9oHMz7YyUBdEewgA:4 a=KRGIpModVpUA:10 Received: by discordia (Postfix, from userid 103) id 3342D16B55D; Mon, 28 Apr 2008 17:18:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.1.8-gr1 (2007-02-13) on discordia X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.8-gr1 Received: from [172.20.1.3] (erwin.int.cokane.org [172.20.1.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by discordia (Postfix) with ESMTP id D30A116B55B; Mon, 28 Apr 2008 17:18:35 -0400 (EDT) From: Coleman Kane To: Ilya Bakulin Content-Type: text/plain; charset=UTF-8 Date: Mon, 28 Apr 2008 17:17:47 -0400 Message-Id: <1209417467.33102.10.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 8bit Cc: freebsd-stable@FreeBSD.org Subject: Re: MFC Candidate: convert ffs_softdep.c over to callout(9) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Apr 2008 21:35:06 -0000 Ilya Bakulin spake thusly: >  > Hi, > I have an ability to test this patch on RELENG_7 system (there is no mission-critical data stored on HDD :-) ) > What sould I do? Just apply patch, recompile kernel and produce some disk load on that system? > > > Hi stable users, > > > > Recently I committed revision 1.219 of src/sys/ufs/ffs/ffs_softdep.c to > > remove the use of old-style timeout(9) calls in the softdep code and > > replace them with the new callout(9) API, to further MPSAFE-ness of the > > softdep code. > > > > I am attaching a patch to RELENG_7 that I'd like some people to test, > > which is just an MFC of this code. Can I get any testers (so that I can > > MFC this)? > > Ilya, Yes just go ahead and apply the patch that was attached. Then rebuild your kernel. Make sure that your softupdates are enabled on the UFS partition(s). Then try hammering it with some sort of file test on that partition (e.g. unpack a somewhat large source tarball and try building it). The kernel did build fine for me when I built it. Unfortunately, due to my hardware, RELENG_7 doesn't "just work" for me from vanilla sources, so I'd like to see some testers on better "supported" hardware. -- Coleman Kane