From owner-svn-src-head@freebsd.org Tue Nov 19 00:18:14 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 043761CDA45 for ; Tue, 19 Nov 2019 00:18:14 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47H5yD5kPdz3GCG for ; Tue, 19 Nov 2019 00:18:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x732.google.com with SMTP id d13so16246553qko.3 for ; Mon, 18 Nov 2019 16:18:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ncXkyjZsyBuGRbN+1mfxzGL93kvmCwm//Nw/9o5wiX8=; b=FVbLMAj/ZGr1S/60cxrFqjniM0ZJ5yP/SplpK92l5fQBqza2lO4Rh9PLbXU0uYovCd QydlDtuyH8AtiwWO8NLQqFtJd9bvIQt66Tqjn3D/n+RWwiruKeqGI8d0/QmlcunCiFeN TSWrKg6vY+9GyFnh5X7j1M304dK8QEYEKUV0L0iZnA66FtsePDKjnKrwh0f8H/kc8gSV faxmOAwoZcs8k0FQpm9vBzMaE1NY0MoiFOPEpHvIhDlcZwF0qrDq0cDn6sNh+CIDcVxu CAudhBpSlUvaBH6Si1MMjUzQA5vpY3gMMme9SbWpAAFI0mflpeHzXGvryyERURAMnMsO ovZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ncXkyjZsyBuGRbN+1mfxzGL93kvmCwm//Nw/9o5wiX8=; b=KfZBeJThvitZJ+Eme7ySrv81otidBaIVMiFhTX0fOa/1gWZFjdVePpDZb+51SQS9wF AcdiQerd0/GB6D3VoZUR9Ptd+dQ/58Opv+hYx2XP/a9KEgHjTpBan9rbMAT4tMi+umRQ 0gjDpgKapvxICW57Tyrl3MYC4S0+P6GNIxcL2UhK0K2ePWuYBOizQMbxSYSXGNisaYdV FGf5gY9lHH+5Ne+o1ghJTBBlFSg/F/8g4AaTJgF84BS7dWi+rNy4juVi8yCQEO7Xd2Bg i08st0aBnOF008ArJOVFtRCn8kNmChQcKsKededL3K3z5b+Fg2Dm++kO4nbfRrbtisiS uAnA== X-Gm-Message-State: APjAAAUlI2Lkf3sJTR3EWGg73+B2UMoR4hiZoV0OFEQMj7+6fewoLixx WkcEr8A5v5idoAf63k1/ca1TLHGhVQSefnTm7NtZmQ== X-Google-Smtp-Source: APXvYqwvff2NN6kQzf3883HPwr8e+No6n0QHdEQXYLQ174CN2OD/QBHy3N+qWjRAPx3TyGT3W+4Ge2TXl47EXHPcmCs= X-Received: by 2002:a37:b0c5:: with SMTP id z188mr27676675qke.215.1574122691161; Mon, 18 Nov 2019 16:18:11 -0800 (PST) MIME-Version: 1.0 References: <201911182330.xAINUcUJ068636@gndrsh.dnsmgr.net> <201911182333.xAINXC1E068666@gndrsh.dnsmgr.net> In-Reply-To: <201911182333.xAINXC1E068666@gndrsh.dnsmgr.net> From: Warner Losh Date: Mon, 18 Nov 2019 17:18:00 -0700 Message-ID: Subject: Re: svn commit: r354824 - head/lib/geom/part To: "Rodney W. Grimes" Cc: Cy Schubert , Mark Johnston , Alexey Dokuchaev , Alan Somers , svn-src-head , svn-src-all , src-committers X-Rspamd-Queue-Id: 47H5yD5kPdz3GCG X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=FVbLMAj/; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::732) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.75 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCPT_COUNT_SEVEN(0.00)[8]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.75)[ip: (-9.40), ipnet: 2607:f8b0::/32(-2.31), asn: 15169(-1.98), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2019 00:18:14 -0000 On Mon, Nov 18, 2019 at 4:40 PM Rodney W. Grimes wrote: > > > In message <20191118204836.GB43295@raichu>, Mark Johnston writes: > > > > On Mon, Nov 18, 2019 at 08:35:30PM +0000, Alexey Dokuchaev wrote: > > > > > On Mon, Nov 18, 2019 at 01:09:19PM -0700, Alan Somers wrote: > > > > > > On Mon, Nov 18, 2019 at 12:48 PM Mark Johnston < > markj@freebsd.org> wrote: > > > > > > > On Mon, Nov 18, 2019 at 12:43:48PM -0700, Alan Somers wrote: > > > > > > > > On Mon, Nov 18, 2019 at 12:06 PM Mark Johnston < > markj@freebsd.org> > > > > > > > wrote: > > > > > > > > > > > > > > > > > Author: markj > > > > > > > > > Date: Mon Nov 18 19:05:52 2019 > > > > > > > > > New Revision: 354824 > > > > > > > > > URL: https://svnweb.freebsd.org/changeset/base/354824 > > > > > > > > > > > > > > > > > > Log: > > > > > > > > > Fix grammar in gpart.8. > > > > > > > > > > > > > > > > > > PR: 241973 > > > > > > > > > MFC after: 3 days > > > > > > > > > > > > > > > > > > Modified: > > > > > > > > > head/lib/geom/part/gpart.8 > > > > > > > > > > > > > > > > Don't forget to bump the .Dd date. > > > > > > > > > > > > > > AFAIK we do not bump .Dd for such changes, only for content > changes. > > > > > > > > > > > > Isn't that a content change? I thought anything displayed to > the user > > > > > > counts as a content change? > > > > > > > > > > I presume that "content" means more like semantic, functional > changes > > > > > that affect some particular meaning. Grammar fixes are just, well, > > > > > grammar fixes and thus do not warrant .Dd bump. > > > > > > > > Indeed, this was always my understanding as well. I can't find a > > > > concrete definition anywhere. I don't understand why it would be > useful > > > > as a user to see the date of the last "content change" if such > changes > > > > might consist only of a small formatting change or typo fix. > > > > > > > > > > Should this be documented in the committers guide? > > > > This should be documented someplace, > > that place probably being where bumping of .Dd is documented as a > minimum. > that place also being where .Dd is documented. > The issue, though, is that we get the mdoc man page from upstream somewhere, so we'd have to change that. Plus, upstream seems to have a different .Dd policy that we do ($Mdocdate$ is the last modification time, for example, in OpenBSD's CVS client). So it's a bit tricky to implement. Warner