From owner-freebsd-office@freebsd.org Mon Feb 18 15:09:18 2019 Return-Path: Delivered-To: freebsd-office@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A6AB514DE5FE for ; Mon, 18 Feb 2019 15:09:18 +0000 (UTC) (envelope-from greg@gregv.net) Received: from aurora.gregv.net (aurora.gregv.net [IPv6:2607:5600:bd::1:1000]) by mx1.freebsd.org (Postfix) with ESMTP id 048656BAE8; Mon, 18 Feb 2019 15:09:18 +0000 (UTC) (envelope-from greg@gregv.net) Received: by aurora.gregv.net (Postfix, from userid 1001) id B5CFC61FD3; Mon, 18 Feb 2019 10:09:17 -0500 (EST) Date: Mon, 18 Feb 2019 10:09:17 -0500 From: Greg Veldman To: Li-Wen Hsu Cc: freebsd-office@freebsd.org, Greg V , Greg Veldman , Jung-uk Kim , Justin Hibbits Subject: Re: [call for help] libreoffice 6.2 update Message-ID: <20190218150917.GB98237@aurora.gregv.net> References: <20190218144218.GA98237@aurora.gregv.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190218144218.GA98237@aurora.gregv.net> User-Agent: Mutt/1.11.2 (2019-01-07) X-Rspamd-Queue-Id: 048656BAE8 X-Spamd-Bar: ++++ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [4.39 / 15.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.95)[0.948,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[gregv.net]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.99)[0.995,0]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: mail.gregv.net]; NEURAL_SPAM_LONG(1.00)[0.995,0]; R_SPF_NA(0.00)[]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:31863, ipnet:2607:5600::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; IP_SCORE(0.47)[asn: 31863(2.40), country: US(-0.07)] X-BeenThere: freebsd-office@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Office applications on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Feb 2019 15:09:18 -0000 On Mon, Feb 18, 2019 at 09:42:18AM -0500, Greg Veldman wrote: > On Tue, Feb 05, 2019 at 11:12:25AM +0800, Li-Wen Hsu wrote: > > Again, LibreOffice 6.2 will be announced soon. I squeezed few hours > > to get most the patches updated > > ( patch-bridges_source_cpp__uno_gcc3__linux__intel_share.hxx > > and patch-bridges_source_cpp__uno_gcc3__linux__intel_uno2cpp.cxx > > still need more work) > > in my working repository: https://github.com/lwhsu/freebsd-ports-libreoffice > > I took a look at this, and now have all patches applying cleanly. > However it appears some of these patches (or parts thereof) may > actually no longer be needed, as upstream changed the arguments > to some of the functions. I'm trying to read/understand the > back story on some of these patches from the various commit logs > to be sure if it's safe to change them.. OK, so that was actually a lot easier than I thought. Looks like the two patches in question were introduced in r395799 to make LibreOffice build on systems with pre-C++-11 compilers (specifically, FreeBSD 9.x). As 9.x hasn't been officially supported in over two years and the base C++ on 11.2 uses C++-14, can I suggest that we just drop these patches rather than trying to carry them forward every time LibreOffice gets updated? -- Greg Veldman greg@gregv.net