Date: Wed, 20 Feb 2013 18:24:49 +0100 From: joerg_surmann <joerg_surmann@snafu.de> To: Florian Smeets <flo@smeets.im>, Freebsd_mailinglist_PORTS <freebsd-ports@freebsd.org> Subject: Re: update failed for security/nss-3.14.3 Message-ID: <512506E1.1010601@snafu.de> In-Reply-To: <5124FE43.9070307@smeets.im> References: <51249B2A.6000600@snafu.de> <5124A303.6070605@FreeBSD.org> <5124D493.4020202@snafu.de> <5124FE43.9070307@smeets.im>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
FreeBSD-9.1 amd64
=2Eif ${ARCH} =3D=3D amd64 --> "Makefile", line 63: Need an operator
+.if exists(${LOCALBASE}/${CONFIGURE_TARGET:S/amd64/x86_64/}/bin) -->=20
"Makefile", line 65: Missing dependency operator
+.else --> "Makefile", line 67: Need an operator
.if defined(WITH_CLANG_IS_CC) || ${CC:Mcc} && ${OSVERSION} > 1000023
--> "Makefile", line 70: Need an operator
Am 20.02.2013 17:48, schrieb Florian Smeets:
>> Am 20.02.2013 11:18, schrieb Alex Dupre:
>>> joerg_surmann wrote:
>>>> hi all,
>>
>>>> can't update security/nss.
>>
>>> INTEL_GCM option of nss is quite flawed.
>>
>>> ifdef INTEL_GCM
>>> #
>>> # GCM binary needs -mssse3
>>> #
>>> $(OBJDIR)/$(PROG_PREFIX)intel-gcm-wrap$(OBJ_SUFFIX): CFLAGS +=3D -mss=
se3
>>
>>> # The integrated assembler in Clang 3.2 does not support % in the
>>> # expression of a .set directive. intel-gcm.s uses .set to give
>>> # symbolic names to registers, for example,
>>> # .set Htbl, %rdi
>>> # So we can't use Clang's integrated assembler with intel-gcm.s.
>>> ifneq (,$(findstring clang,$(AS)))
>>> $(OBJDIR)/$(PROG_PREFIX)intel-gcm$(OBJ_SUFFIX): ASFLAGS +=3D
>>> -no-integrated-as
>>> endif
>>> endif
>>
>>
>>> It requires -mssse3 flag, so it cannot be built on 8.x with base gcc:=
>>
>>> cc1: error: unrecognized command line option "-mssse3"
>>
>>> It uses assembly code not recognized by clang.
>>
>>> I'd say we should disable it to start.
>>
>
> It works fine on anything >=3D 8.3. The problem seems to be that people=
> installed binutils on say 9.0 and have them installed in
>
> /usr/local/x86_64-portbld-freebsd9.0
>
> But they upgraded to 9.1 so the port looks for them in
>
> /usr/local/x86_64-portbld-freebsd9.1
>
> the thing is that -B to gcc falls back to "well known paths" in case it=
> doesn't find anything useful in the specified path (this is even
> documented). Thus using our base linker that's not able to deal with th=
e
> new instructions.
>
> I will probably commit something like this later.
>
> Index: Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- Makefile (revision 312608)
> +++ Makefile (working copy)
> @@ -54,7 +54,11 @@
>
> .if ${ARCH} =3D=3D amd64
> USE_BINUTILS=3D # intel-gcm.s
> +.if exists(${LOCALBASE}/${CONFIGURE_TARGET:S/amd64/x86_64/}/bin)
> CFLAGS+=3D -B${LOCALBASE}/${CONFIGURE_TARGET:S/amd64/x86_64/}/bin
> +.else
> +IGNORE=3D please reinstall devel/binutils and try again
> +.endif
> .if defined(WITH_CLANG_IS_CC) || ${CC:Mcc} && ${OSVERSION} > 1000023
> EXTRA_PATCHES+=3D ${FILESDIR}/extra-bug835050
> .endif
>
> Florian
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
Comment: Using GnuPG with undefined - http://www.enigmail.net/
iQIcBAEBCAAGBQJRJQbhAAoJEDyDkpKh+9pTfXcQAKCpMEIrRIHR38HHV6Q3AZaD
oydDXeXmtSFCiGRy/zOpyCuQVHLt6V4lwgl3ca346XUBfKdl4ftehXA1SCjgOrQp
aEgWD0CLYbqKaoCQNEUrK5GDnlro7pGfxEvVQe6ifJCK/GOQ61beBaYzRQ5ZlpyH
hfdkIzGtEuAso+IN1lGcpfocxFxxyfiiOryYFJLypc3QlpdpEGQuMW/OWmFG0DGb
mjXO4XPYurTfleJSa7cF6PFv4eB6kShPFDrMQyu/YEHa6x+khCjj/ASlkgqGsAcf
wmqLgHhqqpSzKQu+l8Zyz6Pr44umNte/mXiIsj6DCxSjJOlvO3Tje3Dimrb/S4iW
QeeQsYoiW1Ds8P+HkaXe00MqKcf6PcElWeTSxfJGoEx/Ow1SKSunmqctMZ6K/20C
uyXxBjxHwuvtQ/D99YP82cWyv1uifVNcRFlzZj41nId3vztmLSQQZ8EWQId/SU2U
iMDSO95/tnupWI6TTz5cV/gH5Y2U5Zbnq/DNrar0bUjifsYbd7b0P4YnwLLdsMk0
Id1E1L6v2NSOG2PUdrv6AEej5UMrgEAa2aEMd4kYxBQjFbywjuaEaVbDWSSXGNVH
GliHXyTGVviqqxiVfEHpOfLcusBYgGONVduP2046WZYohIVlgc1/c2JizOVuBhhU
essWqgn65piG9E/kPC/H
=3Dy9hZ
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?512506E1.1010601>