From owner-freebsd-current@freebsd.org  Sat Jun 27 04:20:29 2020
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 15401341C34
 for <freebsd-current@mailman.nyi.freebsd.org>;
 Sat, 27 Jun 2020 04:20:29 +0000 (UTC)
 (envelope-from mmacy@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 49v0sm5xDVz4HnD
 for <freebsd-current@freebsd.org>; Sat, 27 Jun 2020 04:20:28 +0000 (UTC)
 (envelope-from mmacy@freebsd.org)
Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com
 [209.85.208.173])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 (Authenticated sender: mmacy)
 by smtp.freebsd.org (Postfix) with ESMTPSA id BDC951D1C4
 for <freebsd-current@freebsd.org>; Sat, 27 Jun 2020 04:20:28 +0000 (UTC)
 (envelope-from mmacy@freebsd.org)
Received: by mail-lj1-f173.google.com with SMTP id h19so12342723ljg.13
 for <freebsd-current@freebsd.org>; Fri, 26 Jun 2020 21:20:28 -0700 (PDT)
X-Gm-Message-State: AOAM531we50TpsiTKhMwRZLVy7JMwayIxX21jE3gzoFWJgtx2mOyVnNf
 EHeHH2sWAejrAB1E2SPwHoaRcXcDDGLb7safhUM=
X-Google-Smtp-Source: ABdhPJy/l/cRFHamr0l9rW3J+Z61tkH0cGENsBhrfqwPigByW1rewdOpwA/TZOiyI88YdQYxag8BYcJ7OVVbRsY5L/4=
X-Received: by 2002:a2e:b0f9:: with SMTP id h25mr3034572ljl.18.1593231627180; 
 Fri, 26 Jun 2020 21:20:27 -0700 (PDT)
MIME-Version: 1.0
References: <f7b2252cfcb26f7035a1e444a5511cbb@neelc.org>
 <BF7D5C05-EE67-4AAB-A4E0-693A683B9628@gmail.com>
In-Reply-To: <BF7D5C05-EE67-4AAB-A4E0-693A683B9628@gmail.com>
From: Matthew Macy <mmacy@freebsd.org>
Date: Fri, 26 Jun 2020 21:20:15 -0700
X-Gmail-Original-Message-ID: <CAPrugNoz2W=ODLk8qbk3gk0vLVoCpx1vR1PBZ=nvyUv4Cot93w@mail.gmail.com>
Message-ID: <CAPrugNoz2W=ODLk8qbk3gk0vLVoCpx1vR1PBZ=nvyUv4Cot93w@mail.gmail.com>
Subject: Re: r362666 breaking buildworld (don't know how to make nvpair.c) &
 Fix/Patch
To: Enji Cooper <yaneurabeya@gmail.com>
Cc: Neel Chauhan <neel@neelc.org>,
 freebsd-current <freebsd-current@freebsd.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Jun 2020 04:20:29 -0000

Well -  it was from his review.

On Fri, Jun 26, 2020 at 8:00 PM Enji Cooper <yaneurabeya@gmail.com> wrote:
>
> (Moving hackers to BCC since the issue is current-related)
>
> > On Jun 26, 2020, at 6:56 PM, Neel Chauhan <neel@neelc.org> wrote:
> >
> > Hi,
> >
> > When I attempt to build world in 13-CURRENT, I get this error:
>
> =E2=80=A6
>
> > The build broke with mmacy@'s commit r362666 which renamed nvpair.c to =
bsd_nvpair.c without renaming the Makefile.
>
> ...
>
> Hi Neel,
>         It looks like the issue was recently fixed in r362669 by mmacy.
> Cheers!
> -Enji