From owner-cvs-src@FreeBSD.ORG  Tue Apr  1 20:53:32 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6A914106564A;
	Tue,  1 Apr 2008 20:53:32 +0000 (UTC)
	(envelope-from emaste@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 5C2FD8FC14;
	Tue,  1 Apr 2008 20:53:32 +0000 (UTC)
	(envelope-from emaste@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m31KrWOs010091;
	Tue, 1 Apr 2008 20:53:32 GMT
	(envelope-from emaste@repoman.freebsd.org)
Received: (from emaste@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m31KrWAl010090;
	Tue, 1 Apr 2008 20:53:32 GMT (envelope-from emaste)
Message-Id: <200804012053.m31KrWAl010090@repoman.freebsd.org>
From: Ed Maste <emaste@FreeBSD.org>
Date: Tue, 1 Apr 2008 20:53:32 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/dev/aac aac.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Apr 2008 20:53:32 -0000

emaste      2008-04-01 20:53:32 UTC

  FreeBSD src repository

  Modified files:
    sys/dev/aac          aac.c 
  Log:
  Calling RequestSupplementAdapterInfo before RequestAdapterInfo appears
  to trip a bug causing the latter to return a zeroed struct
  aac_adapter_info.  This causes two issues.  One is cosmetic only --
  a verbose boot prints information about the controller, and shows all
  zero:
  
  aac0: Unknown processor 0MHz, 0MB memory (0MB cache, 0MB execution),
    unknown battery platform
  
  The second problem is that the firmware version information is stored
  away for aac_rev_check, for userland tools (like aaccli) to query via
  the FSACTL_MINIPORT_REV_CHECK and FSACTL_LNX_MINIPORT_REV_CHECK ioctls.
  When aaccli encounters this issue it prints
  
  Command Error: <The current AFAAPI.DLL is too old to work with the
    current controller software.>
  
  Move the RequestSupplementAdapterInfo call after RequestAdapterInfo,
  which seems to fix both problems.
  
  Revision  Changes    Path
  1.137     +17 -17    src/sys/dev/aac/aac.c