From owner-freebsd-hackers  Mon Apr 14 17:44:29 1997
Return-Path: <owner-hackers>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id RAA28625
          for hackers-outgoing; Mon, 14 Apr 1997 17:44:29 -0700 (PDT)
Received: from phaeton.artisoft.com (phaeton.Artisoft.COM [198.17.250.50])
          by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id RAA28600;
          Mon, 14 Apr 1997 17:44:22 -0700 (PDT)
Received: (from terry@localhost) by phaeton.artisoft.com (8.6.11/8.6.9) id RAA20030; Mon, 14 Apr 1997 17:22:11 -0700
From: Terry Lambert <terry@lambert.org>
Message-Id: <199704150022.RAA20030@phaeton.artisoft.com>
Subject: Re: vnode as filesystem (crash!)
To: toor@dyson.iquest.net (John S. Dyson)
Date: Mon, 14 Apr 1997 17:22:11 -0700 (MST)
Cc: terry@lambert.org, mtaylor@cybernet.com, hackers@freebsd.org,
        bugs@freebsd.org
In-Reply-To: <199704142256.RAA02060@dyson.iquest.net> from "John S. Dyson" at Apr 14, 97 05:56:56 pm
X-Mailer: ELM [version 2.4 PL24]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-hackers@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

> > There is also a FreeBSD ftruncate() case where if the indirect blocks
> > are not zero, FreeBSD will we itself (NetBSD fixed this too).
>
> I didn't know about that.

While we're in the neighborhood... should ftruncate() to a file size
larger than the larget filesize supported return EFBIG, not EINVAL?
It seems the test for the length should be delayed until further into
the function?

Also, the NetBSD code has a bug, where it will call the setsize() before
it tests the length in this particular case...


					Terry Lambert
					terry@lambert.org
---
Any opinions in this posting are my own and not those of my present
or previous employers.