From owner-freebsd-bugs@freebsd.org Fri Jan 20 19:28:10 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3AAE9CB964E for ; Fri, 20 Jan 2017 19:28:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1133A1BF9 for ; Fri, 20 Jan 2017 19:28:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v0KJS9I0059848 for ; Fri, 20 Jan 2017 19:28:09 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 209116] bsdgrep -Fxf failing if earlier non-match is a sub-prefix of the actual match Date: Fri, 20 Jan 2017 19:28:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 9.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: bsdports@kyle-evans.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 19:28:10 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209116 Kyle Evans changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bsdports@kyle-evans.net --- Comment #1 from Kyle Evans --- Created attachment 179160 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D179160&action= =3Dedit WIP patch for poor matching behavior Hi, So the way this works now, if I understand correctly, is it basically ends = up matching each successive pattern against a shorter and shorter subset of the string based on the last match that was made rather than comparing each pat= tern to the full length of the line that we're processing. This feels wrong, and indeed it ends up being wrong. I'm attaching a WIP patch for fixing this. It's still not quite right -- the 'nst' variable that I've added will generally advance the start of future matching to either the end of the line or the end of the last matched patte= rn, depending on how things work out. Do note that I've not yet checked any specifications on this to figure out whether it's expected that we would process again at the end of the shortest match or the end of the longest match, though intuition tells me we likely = want to start processing again at the end of the shortest match. --=20 You are receiving this mail because: You are the assignee for the bug.=