From owner-freebsd-current Fri May 25 22: 2:44 2001 Delivered-To: freebsd-current@freebsd.org Received: from superconductor.rush.net (superconductor.rush.net [208.9.155.8]) by hub.freebsd.org (Postfix) with ESMTP id 34F5C37B422 for ; Fri, 25 May 2001 22:02:42 -0700 (PDT) (envelope-from bright@superconductor.rush.net) Received: (from bright@localhost) by superconductor.rush.net (8.11.2/8.11.2) id f4Q52eo19018; Sat, 26 May 2001 01:02:40 -0400 (EDT) Date: Sat, 26 May 2001 01:02:39 -0400 From: Alfred Perlstein To: Dima Dorfman Cc: current@FreeBSD.ORG Subject: Re: vm_pager_(de)allocate and vm_mtx Message-ID: <20010526010239.G17514@superconductor.rush.net> References: <20010526022209.CA0203E2F@bazooka.unixfreak.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0us In-Reply-To: <20010526022209.CA0203E2F@bazooka.unixfreak.org>; from dima@unixfreak.org on Fri, May 25, 2001 at 07:22:09PM -0700 X-all-your-base: are belong to us. Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Dima Dorfman [010525 22:22] wrote: > Is there a reason vm_pager_allocate acquires vm_mtx itself if > necessary but vm_pager_deallocate does not? At the moment, detaching > an md(4) disk will panic the system with a failed mtx_assert in > vm_pager_deallocate. This can be fixed one of two ways: > vm_pager_deallocate could be made to deal with vm_mtx itself like > vm_pager_allocate does, or md(4) and any other drivers which call > vm_pager_deallocate can be fixed to acquire vm_mtx. So which will it > be? I'll supply patches for either case. Usually fixing the caller is better as it will catch people that expect vm state to remain unchanged across several calls. -- -Alfred Perlstein [alfred@freebsd.org] Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message