From owner-svn-ports-all@FreeBSD.ORG Tue May 6 10:11:05 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5FB977A5 for ; Tue, 6 May 2014 10:11:05 +0000 (UTC) Received: from o3.shared.sendgrid.net (o3.shared.sendgrid.net [208.117.48.85]) by mx1.freebsd.org (Postfix) with SMTP id E9D22DF6 for ; Tue, 6 May 2014 10:11:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info; h=from:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding; s=smtpapi; bh=jF6Iad+3QV4UtOffrDF/y/hwoxY=; b=pjx/Qs5gbpwZv3n+nH bK+GVyiA3MVbqmJQo365eXG7srdCugCM/T3OQ0UT9b3hDqDclQyiE5GcqgzAWtqY l2h7VhylLD42rEFYtPoy6DrtCfwd0YvRTuwau0NSfrGKBCqR/xHM2MkTFKXn4ZW/ gn/aTRlG7yRWPS7rFzreWTmP8= Received: by mf143.sendgrid.net with SMTP id mf143.13500.5368B5305B 2014-05-06 10:10:57.755094942 +0000 UTC Received: from mail.tarsnap.com (unknown [10.100.60.97]) by ismtpd-020 (SG) with ESMTP id 145d103c9d7.490b.1c534d for ; Tue, 06 May 2014 10:10:57 +0000 (GMT) Received: (qmail 71991 invoked from network); 6 May 2014 10:10:57 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by ec2-107-20-205-189.compute-1.amazonaws.com with ESMTP; 6 May 2014 10:10:57 -0000 Received: (qmail 23442 invoked from network); 6 May 2014 10:09:10 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by clamshell.daemonology.net with SMTP; 6 May 2014 10:09:10 -0000 Message-ID: <5368B4C5.4020201@freebsd.org> Date: Tue, 06 May 2014 03:09:09 -0700 From: Colin Percival User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Sunpoet Po-Chuan Hsieh , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r352962 - in head: astro/cfitsio astro/cfitsio/files astro/kstars astro/p5-Astro-FITS-CFITSIO astro/wcslib graphics/gdal graphics/ufraw math/octave-forge-fits science/kst2 References: <201405041537.s44FbBaR044739@svn.freebsd.org> In-Reply-To: <201405041537.s44FbBaR044739@svn.freebsd.org> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SG-EID: RYW4HVJU6vENNcqut+BAw9zj0ZuNvjyPPN906UzwjC9ZSQTqzbPU+WqcNRmnez/j4D42wB/+OIEXIKLux8qBLTeezkRKXakvluYvIwSwzDdjO+M0+SZKWcCUESEZrhilxgvKuDPRAjk9qYKvZegjnmLs85DkK/iUhDt9oqz8RW4= X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 May 2014 10:11:05 -0000 On 05/04/14 08:37, Sunpoet Po-Chuan Hsieh wrote: > Author: sunpoet > Date: Sun May 4 15:37:11 2014 > New Revision: 352962 > URL: http://svnweb.freebsd.org/changeset/ports/352962 > QAT: https://qat.redports.org/buildarchive/r352962/ > > Log: > - Update to 3.360 > - Build and install static library > - Bump PORTREVISION for astro/cfitsio shlib change > > Changes: http://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/docs/changes.txt > > Modified: head/astro/cfitsio/Makefile > ============================================================================== > --- head/astro/cfitsio/Makefile Sun May 4 15:31:38 2014 (r352961) > +++ head/astro/cfitsio/Makefile Sun May 4 15:37:11 2014 (r352962) > +CONFIGURE_ARGS= ZLIB_SOURCES="" ac_cv_prog_FC=f2c > GNU_CONFIGURE= yes > +LDFLAGS+= -L${LIBDIR} -lz > ... > post-patch: > - @${MV} ${WRKSRC}/zlib.h ${WRKSRC}/zlib.h.dist > - @${GREP} -lR "" ${WRKSRC} | ${XARGS} ${REINPLACE_CMD} -e 's|||g' > + @${REINPLACE_CMD} -e 's|$${ZLIB_SOURCES[:=a-z\.]*}||' ${WRKSRC}/Makefile.in This seems to have broken the port -- on FreeBSD 10.0-RELEASE at least, and I'm assuming all older releases as well. The zlib included in the port has functionality (e.g., compress2mem_from_mem) which our zlib doesn't have, and with the port's zlib disabled, dependent ports will fail to build (astro/kstars, which uses libcfitsio) or install (astro/wcslib, which detects the nonfunctional libcfitsio and decides not use it, resulting the the wrong plist). -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid