From owner-freebsd-python@freebsd.org Sat Jan 12 03:30:52 2019 Return-Path: Delivered-To: freebsd-python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F33DD1482D5C for ; Sat, 12 Jan 2019 03:30:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 75F616CE02 for ; Sat, 12 Jan 2019 03:30:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 3040A1482D58; Sat, 12 Jan 2019 03:30:51 +0000 (UTC) Delivered-To: python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E9C1B1482D57 for ; Sat, 12 Jan 2019 03:30:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 888A96CDFF for ; Sat, 12 Jan 2019 03:30:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id B9877131E8 for ; Sat, 12 Jan 2019 03:30:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x0C3UnXe025043 for ; Sat, 12 Jan 2019 03:30:49 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x0C3Una0025042 for python@FreeBSD.org; Sat, 12 Jan 2019 03:30:49 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 234816] [NEW PORT] sysutils/ioc: CLI tool for jail management with libioc{age,ell} Date: Sat, 12 Jan 2019 03:30:49 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: cc bug_status keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jan 2019 03:30:52 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234816 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koobs@FreeBSD.org Status|New |Open Keywords| |needs-patch --- Comment #4 from Kubilay Kocak --- Some review items: - Python ports should almost always be prefixed with PKGNAMEPREFIX=3DPYTHON_PKGNAMEPREFIX. This is particularly the case with po= rts (python packages) that support multiple Python versions, which is almost ev= ery python software in existence. - If pip isn't a *_DEPENDS, remove the commented line, or comment above the commented line as to why it's commented (not yet ported, future reference, whatever) - Add python as a secondary (virtual) CATEGORIES - NO_BUILD=3Dyes - replace with USE_PYTHON=3Ddistutils autoplist (variable = is currently defined but empty incorrectly). Python packages that support these mechanisms should use them in their ports, as it ensures a standard and consistent build / installation, without manual porting. This also obviates= the need to use the custom do-install targets/entries, which are not currently installing things into the correct places (PREFIX/lib, not in the python site-packages dir) - Use USE_RC_SUBR for the rc.d script, after copying the file from WRKSRC to files/ (FILESDIR) at post-extract: time. See: https://www.freebsd.org/doc/en/books/porters-handbook/book.html#rc-scripts - The PORTNAME is not consistent with the setup.py:name (ioc_cli). Since the latter should/will be registered in PyPI (sdist distribution not withstandi= ng), the PORTNAME should match what will eventually be its canonical name. More broadly, there is a naming conflict/confusion created between this and= the dependent port (in bug 234812) born purely from the lack of a prefix (see above). I would standardize/canonicalize the upstream naming, and re-submit patches/port names as follows (feel free to change the canonical names themselves): - sysutils/py-libioc (setup.py:name=3Dlibioc) - sysutils/py-ioc (setup.py:name=3Dioc) Alternatively: - sysutils/py-libioc (setup.py:name=3Dlibioc) - sysutils/py-ioc-cli (setup.py:name=3Dioc-cli) --=20 You are receiving this mail because: You are on the CC list for the bug.=