From owner-cvs-all Mon Dec 11 17:25:48 2000 From owner-cvs-all@FreeBSD.ORG Mon Dec 11 17:25:43 2000 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from io.yi.org (unknown [24.70.218.157]) by hub.freebsd.org (Postfix) with ESMTP id 6453F37B400; Mon, 11 Dec 2000 17:25:43 -0800 (PST) Received: from io.yi.org (localhost.gvcl1.bc.wave.home.com [127.0.0.1]) by io.yi.org (Postfix) with ESMTP id ADEDCBA7D; Mon, 11 Dec 2000 17:25:42 -0800 (PST) X-Mailer: exmh version 2.1.1 10/15/1999 To: Alfred Perlstein Cc: Jake Burkholder , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, jake@io.yi.org Subject: Re: cvs commit: src/sys/conf files src/sys/sys mutex.h src/sys/kern kern_mutex.c src/sys/i386/i386 trap.c src/sys/ia64/ia64 trap.c src/sys/alpha/alpha trap.c In-Reply-To: Message from Alfred Perlstein of "Mon, 11 Dec 2000 17:20:48 PST." <20001211172048.R16205@fw.wintelcom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 11 Dec 2000 17:25:42 -0800 From: Jake Burkholder Message-Id: <20001212012542.ADEDCBA7D@io.yi.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > * Jake Burkholder [001211 17:14] wrote: > > jake 2000/12/11 17:14:33 PST > > > > Modified files: > > sys/conf files > > sys/sys mutex.h > > sys/kern kern_mutex.c > > sys/i386/i386 trap.c > > sys/ia64/ia64 trap.c > > sys/alpha/alpha trap.c > > Log: > > - Add code to detect if a system call returns with locks other than Giant > > held and panic if so (conditional on witness). > > Why not conditional on INVARIANTS? Couldn't this be easily tracked via > a counter in the proc struct? > > I'm trying to find a middle ground where the debug code doesn't make > development unbearable because of the slowdown. MUTEX_DEBUG and WITNESS > make compiling kernels (actually IO) too slow to be tolerated. > Because witness will print out the name(s) of the mutex(s) and the file and line number of where they were acquired. WITNESS isn't dependent on MUTEX_DEBUG anymore, I don't notice any performance problems running with just it enabled. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message