From owner-freebsd-ports@freebsd.org Fri Jul 15 15:22:37 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 08B14B9AFDC for ; Fri, 15 Jul 2016 15:22:37 +0000 (UTC) (envelope-from euan@potensol.com) Received: from smtp.potensol.com (smtp.potensol.com [103.15.233.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.potensol.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BDA9D1ACB; Fri, 15 Jul 2016 15:22:36 +0000 (UTC) (envelope-from euan@potensol.com) Received: from smtp.potensol.com (smtp.potensol.com [103.15.233.195]) by smtp.potensol.com (Postfix) with ESMTP id 8EAB2445ED; Fri, 15 Jul 2016 15:22:31 +0000 (UTC) Received: from webmail.potensol.com (webmail.potensol.com [192.168.10.5]) by smtp.potensol.com (Postfix) with ESMTP id 7C843445EB; Fri, 15 Jul 2016 15:22:30 +0000 (UTC) content-type: text/plain; charset="utf-8" in-reply-to: from: "Euan Thoms" X-Forward: 192.168.10.5 date: Fri, 15 Jul 2016 23:22:30 +0800 cc: =?utf-8?q?Martin_Waschb=C3=BCsch?= , "Walter Schwarzenfeld" , freebsd-ports@freebsd.org to: koobs@FreeBSD.org MIME-Version: 1.0 message-id: <7c8e-5788ff80-3-6b8b4580@96884534> subject: =?utf-8?q?Re=3A?==?utf-8?q?_devel=2Fsope=3A?= make =?utf-8?q?=28stage-qa=29?= now fails with =?utf-8?q?DEVELOPER=3Dyes?= complaining about iconv dependency User-Agent: SOGoMail 2.3.13 content-transfer-encoding: quoted-printable X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 15:22:37 -0000 On Friday, July 15, 2016 15:26 SGT, Kubilay Kocak w= rote: > On 15/07/2016 5:17 PM, Martin Waschb=C3=BCsch wrote: > > > >> Am 14.07.2016 um 23:29 schrieb Euan Thoms : > >> > >> > >> On Friday, July 15, 2016 01:11 SGT, Walter Schwarzenfeld > >> wrote: > >> > >>> I think this statements should be only warnings. Cause not all > >>> of these statements are right and each maintianer should decide > >>> which "USES" or "LIB=5FDEPENDS" are necessairely and which not. > >> > >> Well, I don't know enough to comment about whether it should be > >> classed as a warning or an error. But there's definetely a bug in = > >> the ports Mk system, since adding USES+=3Diconv does not remove th= e > >> error. I don't think I even need iconv as a dependency, it should = > >> be included lower down in the dependency tree. > > > > I am not sure about this. At the very least, sope-core does use ico= nv > > in its NGExtensions (e.g. NSString+Encoding.m). Can we really assum= e > > some lower dependency package already pulls iconv in? > > If something in a port links to libiconv (or anything else), then > the dependency should be registered in that port > OK, thanks guys. I will add libiconv as a LIB=5FDEPENDS. But I still th= ink there may be a bug. The make error tells me to use USES+=3Diconv an= d it doesn't work, I still get the same error about libiconv not being = specified as a dependancy. -- Regards, Euan Thoms