From owner-svn-src-user@FreeBSD.ORG Tue Sep 21 00:07:19 2010 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 463E7106564A; Tue, 21 Sep 2010 00:07:19 +0000 (UTC) (envelope-from weongyo@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 362A08FC0A; Tue, 21 Sep 2010 00:07:19 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o8L07JpC072425; Tue, 21 Sep 2010 00:07:19 GMT (envelope-from weongyo@svn.freebsd.org) Received: (from weongyo@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o8L07JEM072423; Tue, 21 Sep 2010 00:07:19 GMT (envelope-from weongyo@svn.freebsd.org) Message-Id: <201009210007.o8L07JEM072423@svn.freebsd.org> From: Weongyo Jeong Date: Tue, 21 Sep 2010 00:07:19 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r212942 - user/weongyo/usb/sys/dev/usb X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2010 00:07:19 -0000 Author: weongyo Date: Tue Sep 21 00:07:18 2010 New Revision: 212942 URL: http://svn.freebsd.org/changeset/base/212942 Log: Adds XXX comments looking ambiguous. Modified: user/weongyo/usb/sys/dev/usb/usb_busdma.c Modified: user/weongyo/usb/sys/dev/usb/usb_busdma.c ============================================================================== --- user/weongyo/usb/sys/dev/usb/usb_busdma.c Tue Sep 21 00:06:19 2010 (r212941) +++ user/weongyo/usb/sys/dev/usb/usb_busdma.c Tue Sep 21 00:07:18 2010 (r212942) @@ -913,6 +913,7 @@ usb_bdma_work_loop(struct usb_xfer_queue * the USB page caches. */ xfer->frbuffers[0].page_start = pg; + /* XXX why +2 here? It looks it's a quirk */ xfer->frbuffers[0].npage = (frlength_0 / USB_PAGE_SIZE) + 2; info->dma_nframes = nframes; @@ -920,15 +921,18 @@ usb_bdma_work_loop(struct usb_xfer_queue info->dma_frlength_0 = frlength_0; pg += (frlength_0 / USB_PAGE_SIZE); + /* XXX why +2 here? It looks it's a quirk */ pg += 2; while (--nframes > 0) { xfer->frbuffers[nframes].isread = isread; xfer->frbuffers[nframes].page_start = pg; + /* XXX why +2 here? It looks it's a quirk */ xfer->frbuffers[nframes].npage = (xfer->frlengths[nframes] / USB_PAGE_SIZE) + 2; pg += (xfer->frlengths[nframes] / USB_PAGE_SIZE); + /* XXX why +2 here? It looks it's a quirk */ pg += 2; }