From owner-svn-ports-head@freebsd.org Mon Oct 19 10:40:37 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B9ABEA19D50; Mon, 19 Oct 2015 10:40:37 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pa0-x230.google.com (mail-pa0-x230.google.com [IPv6:2607:f8b0:400e:c03::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8A3A3EBF; Mon, 19 Oct 2015 10:40:37 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by padhk11 with SMTP id hk11so26772520pad.1; Mon, 19 Oct 2015 03:40:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:reply-to:subject:references:to:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=o/Ik6rpxtYRmlZA6qvaMsUVqFzc30zMUZhmtEcyVxzc=; b=au4/CUZ08vbXDa77hZ23RcVa0a/2orun3NmTSOh+Yk8xWLf3jW+oUv2S/f2dL3XU8v ZM6Oxg8ATFwHpUWow5nBv1gNYe+ewS4rqz7VqmaMQaTuW1QOR/pBJsFdJkkb64LD4xeh Yp9BExivW0uH3ng4YyNWTMiwwiB4nh8+4yZEkWjwcrPV+YAxwQ0EbCCEC3/tK+2ee02p VM5iYIy4ZzXslUw69pNkd7Ewf9Qgzr5dnqkUNUx4YhDJDE9jskdWfaQDD+kMcejwJ0UG Im2XbwI36z8/fbdYTIvGHhyxZ9StJZ7tqMkhPGOxgZyaEWEzZExeeLOVbxC/wupMgFga sNUQ== X-Received: by 10.68.89.33 with SMTP id bl1mr29715106pbb.139.1445251236395; Mon, 19 Oct 2015 03:40:36 -0700 (PDT) Received: from ?IPv6:2001:44b8:31ae:7b01::1? (2001-44b8-31ae-7b01-0000-0000-0000-0001.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01::1]) by smtp.gmail.com with ESMTPSA id ug4sm35936696pac.11.2015.10.19.03.40.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Oct 2015 03:40:35 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r399654 - head/astro/gpstk References: <201510191018.t9JAIClO040193@repo.freebsd.org> <20151019103454.GA34329@FreeBSD.org> To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, z7dr6ut7gs@snkmail.com From: Kubilay Kocak Message-ID: <5624C89D.2060407@FreeBSD.org> Date: Mon, 19 Oct 2015 21:40:29 +1100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Thunderbird/42.0 MIME-Version: 1.0 In-Reply-To: <20151019103454.GA34329@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Oct 2015 10:40:37 -0000 On 19/10/2015 9:34 PM, Alexey Dokuchaev wrote: >> New Revision: 399654 >> > URL: https://svnweb.freebsd.org/changeset/ports/399654 >> > >> > Log: >> > astro/gpstk: Fix distinfo, Mark Unbroken > It should'be been mentioned that submitter (previous maintainer) had > verified the contents of the old and new tarballs, as he explained in the > PR. Excerpt from it required to be part of the commit log. I don't understand? It 'shouldnt' be mentioned, but I didn't mention it, or did you mean I 'should' have mentioned it? If so, understood. >> > @@ -6,13 +6,13 @@ PORTVERSION= 2.5 >> > CATEGORIES= astro devel >> > MASTER_SITES= SF >> > DISTNAME= ${PORTNAME}-${PORTVERSION}.src >> > +EXTRACT_AFTER_ARGS= --exclude .git >> > >> > MAINTAINER= ports@FreeBSD.org > "Having maintained this port in the past (but got pulled away for a while), > [submitter is] willing to take it again." -- from the PR. I missed this and committed the patch as is. I'll update it accordingly along with a FATAL portlint error that was introduced. >> > -SHA256 (gpstk-2.5.src.tar.gz) = c3be55ea0ea6a08c823b41c51064ab4596f6e1591dc18533816fac86f0087099 >> > -SIZE (gpstk-2.5.src.tar.gz) = 70300615 >> > +SHA256 (gpstk-2.5.src.tar.gz) = 2b70544d301a86c45b68dd9e24df8415f520c3922905274e4d5d2dcdb3234834 >> > +SIZE (gpstk-2.5.src.tar.gz) = 231183550 > I'd suggest asking upstream to properly roll their joints^tarballs next time > they decide to make a release (that is, without .git metainfo). That would be lovely. > ./danfe