From owner-svn-ports-all@FreeBSD.ORG  Tue May  6 11:44:14 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3D968D93;
 Tue,  6 May 2014 11:44:14 +0000 (UTC)
Received: from mail.feld.me (mail.feld.me [66.170.3.6])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mail.feld.me", Issuer "Gandi Standard SSL CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id CA1D9C73;
 Tue,  6 May 2014 11:44:13 +0000 (UTC)
Received: from mail.feld.me (mail.feld.me [66.170.3.6]);
 by mail.feld.me (OpenSMTPD) with ESMTP id 745cd042;
 Tue, 6 May 2014 06:37:31 -0500 (CDT)
Received: from feld@feld.me by mail.feld.me (Archiveopteryx 3.2.0) with
 esmtpa id 1399376249-7156-7139/5/2; Tue, 6 May 2014 11:37:29 +0000
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Date: Tue, 6 May 2014 06:37:29 -0500
From: Mark Felder <feld@FreeBSD.org>
To: "Matthew D. Fuller" <fullermd@over-yonder.net>
Subject: Re: svn commit: r353008 - in head/security: clamav clamav-devel
 clamav-devel/files clamav/files
In-Reply-To: <20140506093123.GI7138@over-yonder.net>
References: <201405051438.s45EcHQZ028890@svn.freebsd.org>
 <20140506093123.GI7138@over-yonder.net>
Message-Id: <c383ed411cefb57d67af9c49da74c1d0@mail.feld.me>
X-Sender: feld@FreeBSD.org
User-Agent: Roundcube Webmail/0.9.5
Sender: feld@feld.me
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 May 2014 11:44:14 -0000

On 2014-05-06 04:31, Matthew D. Fuller wrote:
> On Mon, May 05, 2014 at 02:38:17PM +0000 I heard the voice of
> Mark Felder, and lo! it spake thus:
>> Author: feld
>> Date: Mon May  5 14:38:17 2014
>> New Revision: 353008
>> URL: http://svnweb.freebsd.org/changeset/ports/353008
>> QAT: https://qat.redports.org/buildarchive/r353008/
>>=20
>> Log:
>>   rc script spring cleaning -- now passes rclint
>=20
> I think you accidentally swept the stove outside   :)
>=20
>> Modified: head/security/clamav-devel/files/clamav-milter.in
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> [...]
>> +: ${clamav_milter_flags=3D"-c ${conf_file}"}
> [...]
>>  conf_file=3D%%PREFIX%%/etc/clamav-milter.conf
> [...]
>> -: ${clamav_milter_flags=3D"-c ${conf_file}"}
>=20
> This is now winding up with ${conf_file} being used before defined,
> making the startup process drop a hairball at my feet...

Nice catch. Neither Garga nor myself have ever used clamav-milter and=20
didn't have a test environment to catch what our eyes did not...=20
definitely threw the baby out with the bath water there.

Thanks for the heads up!