Date: Fri, 05 Jan 2018 01:47:34 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 86485] [patch] hexdump(1): hexdump -s speedup on /dev Message-ID: <bug-86485-8-geX4JSgzDw@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-86485-8@https.bugs.freebsd.org/bugzilla/> References: <bug-86485-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D86485 --- Comment #15 from commit-hook@freebsd.org --- A commit references this bug: Author: kevans Date: Fri Jan 5 01:46:41 UTC 2018 New revision: 327567 URL: https://svnweb.freebsd.org/changeset/base/327567 Log: hexdump(1): Speed up -s flag on devices Using the -s flag on devices is extraordinarily slow due to using fseek(3= ) a little too conservatively. Address this by using fseek on character/block devices as well, falling back to getchar(3) only if we fail to seek or we= 're operating on tape drives, where fseek may succeed while not actually being supported. PR: 86485 Submitted by: arundel (originally; modified since then) Reviewed by: cem Differential Revision: https://reviews.freebsd.org/D10939 Changes: head/usr.bin/hexdump/display.c --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-86485-8-geX4JSgzDw>