Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Jul 2011 12:55:10 -0500
From:      Stephen Montgomery-Smith <stephen@missouri.edu>
To:        Jung-uk Kim <jkim@FreeBSD.org>
Cc:        "demon@FreeBSD.org" <demon@FreeBSD.org>, Pav Lucistnik <pav@FreeBSD.org>, Stephen Montgomery-Smith <stephen@FreeBSD.org>, "freebsd-ports@FreeBSD.org" <freebsd-ports@FreeBSD.org>, "lioux@FreeBSD.org" <lioux@FreeBSD.org>
Subject:   Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)
Message-ID:  <4E1F2D7E.4090200@missouri.edu>
In-Reply-To: <201107141347.39261.jkim@FreeBSD.org>
References:  <201107121826.00020.jkim@FreeBSD.org> <4E1E9C79.6080105@FreeBSD.org> <4E1F200D.1080002@missouri.edu> <201107141347.39261.jkim@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 07/14/2011 12:47 PM, Jung-uk Kim wrote:

> Anyhow, I guess we can do it much simpler:
>
> --- Mk/bsd.port.mk      3 Jul 2011 15:51:18 -0000       1.687
> +++ Mk/bsd.port.mk      14 Jul 2011 17:26:43 -0000
> @@ -6432,7 +6432,7 @@
>   		${ECHO_CMD} "@cwd ${DESKTOPDIR}">>  ${TMPPLIST}; \
>   	fi; \
>   	while [ $$# -gt 6 ]; do \
> -		filename="`${ECHO_CMD} "$$4" | ${TR} -cd [:alnum:]`.desktop"; \
> +		filename="`${BASENAME} "$$4" | ${SED} -E 's/[[:space:]]+.*//'`.desktop"; \
>   		pathname="${DESKTOPDIR}/$$filename"; \
>   		categories="$$5"; \
>   		if [ -z "$$categories" ]; then \
>
> I think this is much simpler and better fix.
>
> Jung-uk Kim

I agree.

What about dots at the beginning of the filename?

${SED} -E 's/[[:space:]]+.*//' -E 's/^\.+//'




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E1F2D7E.4090200>