From owner-freebsd-ports@FreeBSD.ORG  Thu Jul 14 17:55:17 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1317710656A7;
	Thu, 14 Jul 2011 17:55:17 +0000 (UTC)
	(envelope-from stephen@missouri.edu)
Received: from wilberforce.math.missouri.edu (wilberforce.math.missouri.edu
	[128.206.184.213])
	by mx1.freebsd.org (Postfix) with ESMTP id BAB758FC1A;
	Thu, 14 Jul 2011 17:55:11 +0000 (UTC)
Received: from [127.0.0.1] (wilberforce.math.missouri.edu [128.206.184.213])
	by wilberforce.math.missouri.edu (8.14.4/8.14.4) with ESMTP id
	p6EHtA8I006141; Thu, 14 Jul 2011 12:55:10 -0500 (CDT)
	(envelope-from stephen@missouri.edu)
Message-ID: <4E1F2D7E.4090200@missouri.edu>
Date: Thu, 14 Jul 2011 12:55:10 -0500
From: Stephen Montgomery-Smith <stephen@missouri.edu>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.9.2.17) Gecko/20110516 Thunderbird/3.1.10
MIME-Version: 1.0
To: Jung-uk Kim <jkim@FreeBSD.org>
References: <201107121826.00020.jkim@FreeBSD.org>
	<4E1E9C79.6080105@FreeBSD.org> <4E1F200D.1080002@missouri.edu>
	<201107141347.39261.jkim@FreeBSD.org>
In-Reply-To: <201107141347.39261.jkim@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "demon@FreeBSD.org" <demon@FreeBSD.org>, Pav Lucistnik <pav@FreeBSD.org>,
	Stephen Montgomery-Smith <stephen@FreeBSD.org>,
	"freebsd-ports@FreeBSD.org" <freebsd-ports@FreeBSD.org>,
	"lioux@FreeBSD.org" <lioux@FreeBSD.org>
Subject: Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jul 2011 17:55:17 -0000

On 07/14/2011 12:47 PM, Jung-uk Kim wrote:

> Anyhow, I guess we can do it much simpler:
>
> --- Mk/bsd.port.mk      3 Jul 2011 15:51:18 -0000       1.687
> +++ Mk/bsd.port.mk      14 Jul 2011 17:26:43 -0000
> @@ -6432,7 +6432,7 @@
>   		${ECHO_CMD} "@cwd ${DESKTOPDIR}">>  ${TMPPLIST}; \
>   	fi; \
>   	while [ $$# -gt 6 ]; do \
> -		filename="`${ECHO_CMD} "$$4" | ${TR} -cd [:alnum:]`.desktop"; \
> +		filename="`${BASENAME} "$$4" | ${SED} -E 's/[[:space:]]+.*//'`.desktop"; \
>   		pathname="${DESKTOPDIR}/$$filename"; \
>   		categories="$$5"; \
>   		if [ -z "$$categories" ]; then \
>
> I think this is much simpler and better fix.
>
> Jung-uk Kim

I agree.

What about dots at the beginning of the filename?

${SED} -E 's/[[:space:]]+.*//' -E 's/^\.+//'