Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 30 Aug 2012 11:36:48 -0700
From:      Jason Helfman <jgh@FreeBSD.org>
To:        "apache@FreeBSD.org" <apache@FreeBSD.org>
Subject:   Re: apache-2.2.22_6 question
Message-ID:  <20120830183648.GA36263@dormouse.experts-exchange.com>
In-Reply-To: <503FB2A2.7080007@gmx.de>
References:  <20120830174029.GM63706@dormouse.experts-exchange.com> <503FAE12.8070201@FreeBSD.org> <503FB2A2.7080007@gmx.de>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Aug 30, 2012 at 08:36:18PM +0200, olli hauer thus spake:
>On 2012-08-30 20:16, Olli Hauer wrote:
>> On 2012-08-30 19:40, Jason Helfman wrote:
>>> Hi,
>>>
>>> I was wondering what implications there are of building apache-2.2.22_6
>>> against pcre version of 8.02?
>>>
>>> I believe a patch addressed a deprecated function of pcre, however at the
>>> moment I am unable to update a snapshotted portstree to a current
>>> version, or even move to a newer tree.
>>>
>>> I don't know if it would build with that patch, or without the patch, and if
>>> that would be good, or not, and what implications there may be as a result.
>>>
>>> Many Thanks!
>>>
>>> -jgh
>>>
>>
>> Hi Jason,
>>
>> exact, the bump and patch was done because pcre removed a (long) deprecated function.
>> pcre-8.02 will full support the patch because the new api was in this version already
>> the default.
>>
>> file pcre-8.02/pcreposix.c (around line 265)
>> --------------------------------------------
>> preg->re_nsub = pcre_info((const pcre *)preg->re_pcre, NULL, NULL);
>> return 0;
>> }
>>
>>
>> apache22/files/files/patch-server__util_pcre.c
>> ----------------------------------------------
>> -preg->re_nsub = pcre_info((const pcre *)preg->re_pcre, NULL, NULL);
>> +pcre_fullinfo((const pcre *)preg->re_pcre, NULL,
>> +               PCRE_INFO_CAPTURECOUNT, &(preg->re_nsub));
>>
>>
>
>Ups, pcre_info != pcre_fullinfo.
>
>But pcre_fullinfo is already in 8.02 present, so I assume it will work with the patch.

Is there any testing that we can do that would verify this? Perhaps doing
any particular tests that would exercise the regular expression library?

Thanks, again.
-jgh
-- 
Jason Helfman
FreeBSD Committer | http://people.freebsd.org/~jgh | The Power To Serve



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120830183648.GA36263>