From owner-freebsd-apache@FreeBSD.ORG Thu Aug 30 18:39:07 2012 Return-Path: Delivered-To: apache@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 79AEE1065673 for ; Thu, 30 Aug 2012 18:39:07 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com [209.85.210.54]) by mx1.freebsd.org (Postfix) with ESMTP id 407838FC12 for ; Thu, 30 Aug 2012 18:39:07 +0000 (UTC) Received: by dadr6 with SMTP id r6so1388314dad.13 for ; Thu, 30 Aug 2012 11:39:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-operating-system :organization:x-living-the-dream:x-pgp-fingerprint:x-pgp-key :user-agent:x-gm-message-state; bh=jv219IlrVBMR2OIuQwNp0W4zpqsWcEQxp8B2cxMBRN8=; b=mAJjr3cBhmNDRmBolDyyX1kiGMSes5l5ew5pQY2G9qaqvFDc/+BQbvba9u26poyEy/ 7Q9tQCko7Cgpw+qlGIA0KYJvSCqeuG8Jevc9JlKkvtDZBifWWhnnu8StrV3m/YoCPAdT ISLvwZPm2wWRxjp0VXO3Kri6NwJXlXtgC1QnvVyUXmNWlX56j9D7WB77j+X9TGil6ErW CE6GbiN7BrwtzueYvGlnTLfp/DShfekYY7xVGKGtZKn50GoT3TP6RRvVIYh7LMXc3XDI nht2cFvxucSNf7J93q/zxtAMoZAGCsQA1419eyU7b773F9WLeJQ3Hec2LioPLsie7gjA 1i+g== Received: by 10.68.223.164 with SMTP id qv4mr9448830pbc.20.1346351946476; Thu, 30 Aug 2012 11:39:06 -0700 (PDT) Received: from dormouse.experts-exchange.com ([72.29.164.238]) by mx.google.com with ESMTPS id ky8sm1989902pbc.43.2012.08.30.11.39.04 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 30 Aug 2012 11:39:05 -0700 (PDT) Sender: Jason Helfman Date: Thu, 30 Aug 2012 11:36:48 -0700 From: Jason Helfman To: "apache@FreeBSD.org" Message-ID: <20120830183648.GA36263@dormouse.experts-exchange.com> References: <20120830174029.GM63706@dormouse.experts-exchange.com> <503FAE12.8070201@FreeBSD.org> <503FB2A2.7080007@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <503FB2A2.7080007@gmx.de> X-Operating-System: FreeBSD 8.3-RELEASE amd64 Organization: The FreeBSD Project, http://www.freebsd.org X-Living-The-Dream: I love the SLO Life! X-PGP-FingerPrint: 8E0D C457 9A0F C91C 23F3 0454 2059 9A63 4150 D3DC X-PGP-Key: http://people.freebsd.org/~jgh/jgh.asc User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQnK6Ih7RxKqdWTONuDhwfWnevCqmmLdSc2I4E5FYIXYYaaydZpOai4TTr5QLBO3w+5vF1u9 Cc: Subject: Re: apache-2.2.22_6 question X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2012 18:39:07 -0000 On Thu, Aug 30, 2012 at 08:36:18PM +0200, olli hauer thus spake: >On 2012-08-30 20:16, Olli Hauer wrote: >> On 2012-08-30 19:40, Jason Helfman wrote: >>> Hi, >>> >>> I was wondering what implications there are of building apache-2.2.22_6 >>> against pcre version of 8.02? >>> >>> I believe a patch addressed a deprecated function of pcre, however at the >>> moment I am unable to update a snapshotted portstree to a current >>> version, or even move to a newer tree. >>> >>> I don't know if it would build with that patch, or without the patch, and if >>> that would be good, or not, and what implications there may be as a result. >>> >>> Many Thanks! >>> >>> -jgh >>> >> >> Hi Jason, >> >> exact, the bump and patch was done because pcre removed a (long) deprecated function. >> pcre-8.02 will full support the patch because the new api was in this version already >> the default. >> >> file pcre-8.02/pcreposix.c (around line 265) >> -------------------------------------------- >> preg->re_nsub = pcre_info((const pcre *)preg->re_pcre, NULL, NULL); >> return 0; >> } >> >> >> apache22/files/files/patch-server__util_pcre.c >> ---------------------------------------------- >> -preg->re_nsub = pcre_info((const pcre *)preg->re_pcre, NULL, NULL); >> +pcre_fullinfo((const pcre *)preg->re_pcre, NULL, >> + PCRE_INFO_CAPTURECOUNT, &(preg->re_nsub)); >> >> > >Ups, pcre_info != pcre_fullinfo. > >But pcre_fullinfo is already in 8.02 present, so I assume it will work with the patch. Is there any testing that we can do that would verify this? Perhaps doing any particular tests that would exercise the regular expression library? Thanks, again. -jgh -- Jason Helfman FreeBSD Committer | http://people.freebsd.org/~jgh | The Power To Serve