From owner-freebsd-bugs@FreeBSD.ORG  Mon Mar 28 20:00:09 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 23A2916A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 28 Mar 2005 20:00:09 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F127843D54
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 28 Mar 2005 20:00:06 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j2SK06fe041301
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 28 Mar 2005 20:00:06 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j2SK06NW041298;
	Mon, 28 Mar 2005 20:00:06 GMT
	(envelope-from gnats)
Resent-Date: Mon, 28 Mar 2005 20:00:06 GMT
Resent-Message-Id: <200503282000.j2SK06NW041298@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Derek Tattersall <dtatters@gmail.conm>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3301D16A4CE
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon, 28 Mar 2005 19:51:42 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1778843D54
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon, 28 Mar 2005 19:51:42 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j2SJpdbY046514
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 28 Mar 2005 19:51:39 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j2SJpdb2046513;
	Mon, 28 Mar 2005 19:51:39 GMT
	(envelope-from nobody)
Message-Id: <200503281951.j2SJpdb2046513@www.freebsd.org>
Date: Mon, 28 Mar 2005 19:51:39 GMT
From: Derek Tattersall <dtatters@gmail.conm>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Subject: misc/79318: Example in archive_read man page is incorrect
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Mar 2005 20:00:09 -0000


>Number:         79318
>Category:       misc
>Synopsis:       Example in archive_read man page is incorrect
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 28 20:00:06 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Derek Tattersall
>Release:        Current
>Organization:
>Environment:
($?=1)dlt@lorne 1076 dlt% uname -a
FreeBSD lorne.arm.org 6.0-CURRENT FreeBSD 6.0-CURRENT #24: Sun Mar 20 12:26:22 EST 2005     root@lorne.arm.org:/usr/obj/usr/src/sys/LORNE  i386
     
>Description:
      Man page, archive_read.3, has a mistake in the example code, myopen() function.  The return value does not agree with the description of the routine, nor with the libarchive code.
>How-To-Repeat:
Construct an example using the code from the man page.
>Fix:
    --- /usr/src/lib/libarchive/archive_read.3      Sun Feb 20 10:54:50 2005
+++ ./archive_read.3    Mon Mar 28 14:44:07 2005
@@ -389,7 +389,7 @@
   struct mydata *mydata = client_data;
 
   mydata->fd = open(mydata->name, O_RDONLY);
-  return (mydata->fd >= 0);
+  return (mydata->fd >= 0 ? ARCHIVE_OK : ARCHIVE_FATAL);
 }
 
 int

>Release-Note:
>Audit-Trail:
>Unformatted: