From owner-freebsd-ports@freebsd.org Fri May 14 22:32:45 2021 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A712A62E2D7 for ; Fri, 14 May 2021 22:32:45 +0000 (UTC) (envelope-from portmaster@bsdforge.com) Received: from udns.ultimatedns.net (static-24-113-41-81.wavecable.com [24.113.41.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "ultimatedns.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fhjvx38xtz4dlM for ; Fri, 14 May 2021 22:32:44 +0000 (UTC) (envelope-from portmaster@bsdforge.com) Received: from ultimatedns.net (localhost [127.0.0.1]) by udns.ultimatedns.net (8.16.1/8.16.1) with ESMTP id 14EMWYPV098555; Fri, 14 May 2021 15:32:40 -0700 (PDT) (envelope-from portmaster@bsdforge.com) MIME-Version: 1.0 Date: Fri, 14 May 2021 15:32:34 -0700 From: Chris To: Christoph Moench-Tegeder Cc: freebsd-ports Subject: Re: pkg-fallout: License not correctly defined: defining both LICENSE_FILE and LICENSE_TEXT is not allowed In-Reply-To: References: <50a92b1644e8fa43f16d59aa013ca10d@bsdforge.com> <6a5d5af22c863c1b5284885d39bf1129@bsdforge.com> <7682e483d97004434d8b77ebdd1d0e3d@bsdforge.com> User-Agent: UDNSMS/17.0 Message-ID: <8b10c044b1e3b930bc2d01d82e30b484@bsdforge.com> X-Sender: portmaster@bsdforge.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Fhjvx38xtz4dlM X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; ASN(0.00)[asn:11404, ipnet:24.113.0.0/16, country:US]; local_wl_ip(0.00)[24.113.41.81] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 May 2021 22:32:45 -0000 On 2021-05-14 15:15, Christoph Moench-Tegeder wrote: > ## Chris (portmaster@bsdforge.com): > >> The problem I'm addressing in this case; is that the following as >> *always* worked for licenses which carried a copy in >> ${WRKSRC}/LICENSE_NAME: > > The problem you're trying to address is only a consecutive error and > not the real problem. > As I wrote in my first reply: > : Foremost, that Makefile has an .include, and that's where the mess > : (for this use case) happens. DO'H! Sorry. I've been fairly overwhelmed w/$DAYJOB so *clearly* glossed over that (important) section. Thank you for taking the time to use your "clue bat" on me. :-) Yes. That's *exactly* why the error(s) are occurring. The only question I have at this juncture; is *why* after some ~5yrs later is it *now* throwing an error? Oh well. In any case, I can easily resolve the problem and set things straight with these ports. Thanks again! :-) --Chris > > An .include includes the given file at that point (duh), and in this > case that's kde-icons-noia/Makefile.icons, which overwrites your > LICENSE variables (and brings in LICENSE_TEXT). And, as stated before: > that cannot be your intention (and including kde-icons-noia/Makefile.icons > only makes sense in a very limited number of ports if at all). And you > can (and should, in case of doubt or problems) double-check your > variables by running e.g. "make -V LICENSE" in the port's directory > (or "make -C -V ", yadda yadda, make(1), etc). > >> > you're not allowed to just put another license on that port. >> I'm not. It's a verbatim LGPL3 port && license as reported >> within the port' source. :-) > > : cmt: x11-themes/kde-icons-nuovext2$ make -V LICENSE > : theme > > That's not LGPL3. > > Regards, > Christoph