Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 11 May 2015 19:18:50 +0000
From:      Brooks Davis <brooks@freebsd.org>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        Xin LI <delphij@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r282672 - head/etc/rc.d
Message-ID:  <20150511191850.GC68045@spindle.one-eyed-alien.net>
In-Reply-To: <C072FED2-FBED-4EF9-9D74-11B485594AD7@FreeBSD.org>
References:  <201505082336.t48NaWRS080408@svn.freebsd.org> <C072FED2-FBED-4EF9-9D74-11B485594AD7@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, May 10, 2015 at 03:45:48PM -0400, John Baldwin wrote:
> 
> > On May 8, 2015, at 19:36, Xin LI <delphij@FreeBSD.org> wrote:
> > 
> > Author: delphij
> > Date: Fri May  8 23:36:31 2015
> > New Revision: 282672
> > URL: https://svnweb.freebsd.org/changeset/base/282672
> > 
> > Log:
> >  Always convert uuid to lower case.
> > 
> >  MFC after:    2 weeks
> > 
> > Modified:
> >  head/etc/rc.d/hostid
> > 
> > Modified: head/etc/rc.d/hostid
> > ==============================================================================
> > --- head/etc/rc.d/hostid    Fri May  8 23:29:42 2015    (r282671)
> > +++ head/etc/rc.d/hostid    Fri May  8 23:36:31 2015    (r282672)
> > @@ -58,7 +58,7 @@ hostid_set()
> > 
> > valid_hostid()
> > {
> > -    uuid=$1
> > +    uuid=$(echo $1 | tr '[:upper:]' '[:lower:]')
> 
> tr is in /usr/bin so this breaks systems with a separate /usr.  Perhaps you could use dd with conv=lcase instead?

Alterntively, a shell function "ltr" exists in rc.subr for this purpose.

-- Brooks



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150511191850.GC68045>