Date: Sat, 13 Jan 2018 09:41:03 -0500 From: Dan Langille <dan@langille.org> To: Sergey A Osokin <osa@FreeBSD.org> Cc: FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: www/rubygem-passenger creating slave ports Message-ID: <83631DA6-2AEF-4C1F-A2A2-13B3FE3CD4B0@langille.org> In-Reply-To: <20180113011121.GG9882@FreeBSD.org> References: <E354E8AD-DEF3-4EFA-9F1D-EEDF7ADA73B9@langille.org> <20180113003346.GF9882@FreeBSD.org> <A02AE759-2163-4151-84C3-A8A73A905E68@langille.org> <20180113011121.GG9882@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Sergey, Romain Tarti=C3=A8re (romain@) has just commented at = https://reviews.freebsd.org/D13889: "Great, this has annoyed me for a while, I fixed this upstream but this = has not been released yet. Patching will therefore become useless in the = future, but for now, thanks for fixing this!" Given the port will need to be redone when this new feature is released, = I would like to proceed, with your approval, with the two slave ports as = an interim measure. This will all be redundant once ruby FLAVORs are in. Thank you. --=20 Dan Langille - BSDCan / PGCon dan@langille.org > On Jan 12, 2018, at 8:11 PM, Sergey A. Osokin <osa@FreeBSD.org> wrote: >=20 > Hi Dan, >=20 > my suggestion in this case is to try to play with next options > in www/rubygem-passenger: >=20 > OPTIONS_SINGLE=3D SERVER > OPTIONS_SINGLE_SERVER=3D APACHE22 NGINX >=20 > Again, I believe it's possible to modify www/rubygem-passenger to > have ability to install necessary files to support one of them > (apache or nginx) or even both technologies. >=20 > --=20 > Sergey A. Osokin >=20 > On Fri, Jan 12, 2018 at 08:02:08PM -0500, Dan Langille wrote: >> Hello Sergey, >>=20 >> The proposed solution is a short term solution which goes away when = FLAVORS are done for ruby. This is not soon.=20 >>=20 >> We (feld@ & I) choose this solution as it has very little affect on = the existing port.=20 >>=20 >> The need arose today & we hope to proceed quickly with whatever can = be done.=20 >>=20 >> How do you suggest we proceed with the work? >>=20 >> Thank you >>=20 >> --=20 >> Dan Langille >> http://langille.org/ >>=20 >>=20 >>> On Jan 12, 2018, at 7:33 PM, Sergey A. Osokin <osa@FreeBSD.org> = wrote: >>>=20 >>> Hi Dan, >>>=20 >>> I don't see any reason to create two separate ports in this case and = support >>> them then cause potentially it's possible to modify the existing = port to get >>> the same result. >>>=20 >>> --=20 >>> Sergey A. Osokin >>>=20 >>>> On Fri, Jan 12, 2018 at 10:18:37AM -0500, Dan Langille wrote: >>>> Sergey, >>>>=20 >>>> We have a need to use rubygem-passenger with both Nginx and with = Apache (on different servers). >>>>=20 >>>> I propose to create two new slave ports: >>>>=20 >>>> * www/rubygem-passenger-nginx >>>> * www/rubygem-passenger-passenger >>>>=20 >>>> To do this, I would like to make a one-line change to the master = port: >>>>=20 >>>>=20 >>>> Index: Makefile >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>> --- Makefile (revision 458852) >>>> +++ Makefile (working copy) >>>> @@ -24,7 +24,7 @@ >>>> APACHE22_DESC=3D Build with apache22 support >>>> NGINX_DESC=3D Build with nginx support >>>> SYMLINK_DESC=3D Create passenger symlink >>>> -OPTIONS_DEFAULT=3D APACHE22 >>>> +OPTIONS_DEFAULT=3D? APACHE22 >>>>=20 >>>> USE_RUBY=3D yes >>>> RAKE_BIN=3D ${LOCALBASE}/bin/rake >>>>=20 >>>> This will allow the slave port to set OPTIONS_DEFAULT and build for = the desired web server. >>>>=20 >>>> If you agree, I am happen to make the commit / submit a patch for = your approval. >>>>=20 >>>> Thank you. >>>>=20 >>>> --=20 >>>> Dan Langille - BSDCan / PGCon >>>> dan@langille.org >>>>=20 >>>>=20 >>=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?83631DA6-2AEF-4C1F-A2A2-13B3FE3CD4B0>