From owner-cvs-src-old@FreeBSD.ORG Thu Dec 18 12:01:38 2008 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B8AE31065690 for ; Thu, 18 Dec 2008 12:01:38 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A76558FC29 for ; Thu, 18 Dec 2008 12:01:38 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id mBIC1cWb030081 for ; Thu, 18 Dec 2008 12:01:38 GMT (envelope-from kib@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id mBIC1cMs030080 for cvs-src-old@freebsd.org; Thu, 18 Dec 2008 12:01:38 GMT (envelope-from kib@repoman.freebsd.org) Message-Id: <200812181201.mBIC1cMs030080@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to kib@repoman.freebsd.org using -f From: Konstantin Belousov Date: Thu, 18 Dec 2008 12:01:19 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern vfs_syscalls.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2008 12:01:38 -0000 kib 2008-12-18 12:01:19 UTC FreeBSD src repository Modified files: sys/kern vfs_syscalls.c Log: SVN rev 186277 on 2008-12-18 12:01:19Z by kib The quotactl, statfs and fstatfs syscall implementations may dereference NULL pointer to struct mount if the looked up vnode is reclaimed. Also, these syscalls only mnt_ref() the mp, still allowing it to be unmounted; only struct mount memory is kept from being reused. Lock the vnode when doing name lookup, then reference its mount point, unlock the vnode and vfs_busy the mountpoint. This sequence shall take care of both races. Reported and tested by: pho Discussed with: attilio MFC after: 1 month Revision Changes Path 1.467 +18 -6 src/sys/kern/vfs_syscalls.c