Date: Mon, 4 Sep 2017 13:29:05 +1000 From: Kubilay Kocak <koobs@FreeBSD.org> To: Rene Ladan <rene@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Cc: "python@freebsd.org" <python@freebsd.org> Subject: Re: svn commit: r449195 - head/security/py-cryptography Message-ID: <96b4bb9f-dc46-ffea-bd49-a5949b5b7365@FreeBSD.org> In-Reply-To: <201709031028.v83AS09e027702@repo.freebsd.org> References: <201709031028.v83AS09e027702@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/3/17 8:28 PM, Rene Ladan wrote: > Author: rene > Date: Sun Sep 3 10:28:00 2017 > New Revision: 449195 > URL: https://svnweb.freebsd.org/changeset/ports/449195 > > Log: > security/py-cryptography: remove support for expired Python 3.3 > > Modified: > head/security/py-cryptography/Makefile > > Modified: head/security/py-cryptography/Makefile > ============================================================================== > --- head/security/py-cryptography/Makefile Sun Sep 3 10:12:26 2017 (r449194) > +++ head/security/py-cryptography/Makefile Sun Sep 3 10:28:00 2017 (r449195) > @@ -35,8 +35,6 @@ RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}ipaddress>0:net/p > > .if ${PYTHON_REL} < 3300 > RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}enum34>0:devel/py-enum34 > -.elif ${PYTHON_REL} < 3400 > -RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}enum34>0:devel/py3-enum34 > .endif > > post-install: > Please revert this change: - It is *meant* to include all versions below 3.4, including 2.7 - It is not necessary to delete when a python language port version is removed. The block still semantically and correctly declares the valid version dependency requirements from the upstream, independently from what the tree has at any point in time. Also, if you could, please ask/talk to python maintainers and/or python@ with regard to port deprecation/deletions before committing. It is not always entirely obvious or explicit what is the correct thing to do is without fully understanding the versions support and semantics completely.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?96b4bb9f-dc46-ffea-bd49-a5949b5b7365>