From owner-freebsd-current@FreeBSD.ORG Tue Feb 27 17:37:23 2007 Return-Path: X-Original-To: freebsd-current@mx1.freebsd.org Delivered-To: freebsd-current@mx1.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 34BCE16A405 for ; Tue, 27 Feb 2007 17:37:23 +0000 (UTC) (envelope-from piso@newluxor.wired.org) Received: from mail.oltrelinux.com (krisma.oltrelinux.com [194.242.226.43]) by mx1.freebsd.org (Postfix) with ESMTP id E642013C471 for ; Tue, 27 Feb 2007 17:37:20 +0000 (UTC) (envelope-from piso@newluxor.wired.org) Received: from newluxor.wired.org (ip-91-186.sn1.eutelia.it [62.94.91.186]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.oltrelinux.com (Postfix) with ESMTP id 46E1D11AEB1; Tue, 27 Feb 2007 18:37:20 +0100 (CET) Received: (from piso@localhost) by newluxor.wired.org (8.13.8/8.13.8/Submit) id l1RHaq5h002670; Tue, 27 Feb 2007 18:36:52 +0100 (CET) (envelope-from piso) Date: Tue, 27 Feb 2007 18:36:39 +0100 From: Paolo Pisati To: Paolo Pisati Message-ID: <20070227173639.GA2175@tin.it> References: <20070227145259.GB1655@tin.it> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070227145259.GB1655@tin.it> User-Agent: Mutt/1.4.2.2i X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at krisma.oltrelinux.com Cc: freebsd-current@mx1.freebsd.org, Goran Gajic Subject: Re: em0+msi related panic X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2007 17:37:23 -0000 On Tue, Feb 27, 2007 at 03:52:59PM +0100, Paolo Pisati wrote: > > No, wait, em_intr_fast() was supposed to run as an INTR_FAST (that's > where it gets the suffix '_fast'), and since the bus_setup_intr() > modification to define an INTR_FAST/filter, you use the driver_filter_t > arg, so: > > bus_setup_intr(dev, adapter->res_interrupt, INTR_TYPE_NET, > em_intr_fast,NULL adapter, &adapter->int_handler_tag) > > is the correct one. > Moreover, all the filter handlers (ex INTR_FAST) return a status > about interrupt handling, so em_intr_fast() prototype and return code > are corrects. a fix was just committed to HEAD: look for sys/kern/kern_intr.c rev: 1.141. bye, P.