From owner-freebsd-geom@FreeBSD.ORG Tue Jun 3 22:27:42 2014 Return-Path: Delivered-To: geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AD9BC61F; Tue, 3 Jun 2014 22:27:42 +0000 (UTC) Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72]) by mx1.freebsd.org (Postfix) with ESMTP id 6B27F2249; Tue, 3 Jun 2014 22:27:41 +0000 (UTC) Received: from localhost (89-78-109-105.dynamic.chello.pl [89.78.109.105]) by mail.dawidek.net (Postfix) with ESMTPSA id 7D5FF667; Wed, 4 Jun 2014 00:17:34 +0200 (CEST) Date: Wed, 4 Jun 2014 00:20:53 +0200 From: Pawel Jakub Dawidek To: geom@freebsd.org Subject: Re: diskid documentation Message-ID: <20140603222053.GA1673@garage.freebsd.pl> References: <20140601134147.GA99583@bewilderbeast.blackhelicopters.org> <538C7B71.20109@freebsd.org> <20140602153651.GB4116@bewilderbeast.blackhelicopters.org> <20140602180108.GX43976@funkthat.com> <20140602202639.GA1668@garage.freebsd.pl> <20140602222706.GA43976@funkthat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+QahgC5+KEYLbs62" Content-Disposition: inline In-Reply-To: <20140602222706.GA43976@funkthat.com> X-OS: FreeBSD 11.0-CURRENT amd64 User-Agent: Mutt/1.5.22 (2013-10-16) Cc: FreeBSD Current , Ryan Stone , "Michael W. Lucas" , Allan Jude X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jun 2014 22:27:42 -0000 --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 02, 2014 at 03:27:06PM -0700, John-Mark Gurney wrote: > Pawel Jakub Dawidek wrote this message on Mon, Jun 02, 2014 at 22:26 +020= 0: > > The problem is that GPT labels (or GPT IDs for that matter) should not > > be implemented within GLABEL. This is wrong. It should be implemented as > > part of GPART, so that GPART would create ada0p1, gpt/label and > > gptid/whatever. Opening one of those should not make the others > > disappear then. Only opening ada0 for writting would make them disappea= r. >=20 > even gpart would be wrong IMO... What happens if there is another > provider like GPART, but different, do they need to implement diskid > creation too to prevent the same issue? >=20 > Shouldn't geom be updated to say, this ident is an alias, everything > you do w/ this, it's exactly the same as the other one? This would > also have the advantage of possibly removing one layer in the call > chain when dealing w/ IO. (or does GEOM has a pass-through flag that > says, I don't do anything, just skip me?) As for disk IDs it definitely shouldn't be implemented in GPART or GLABEL. IMHO the right place is the DISK class - both ada0 and diskid-of-ada0 should exist on the same rights (two providers of one geom). This also would address your concern about additional layer. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://mobter.com --+QahgC5+KEYLbs62 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iEYEARECAAYFAlOOSkUACgkQForvXbEpPzR3XwCgiwMgRoi6Sa+5RUjHfv1A2pWh 8UkAn2fzJmdbmuiI/K4mhck1s3xJLEgW =LBL6 -----END PGP SIGNATURE----- --+QahgC5+KEYLbs62--