From owner-p4-projects@FreeBSD.ORG  Thu Apr  8 16:43:57 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id C7A45106567A; Thu,  8 Apr 2010 16:43:57 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8B0BA1065676;
	Thu,  8 Apr 2010 16:43:57 +0000 (UTC)
	(envelope-from raj@semihalf.com)
Received: from smtp.semihalf.com (smtp.semihalf.com [213.17.239.109])
	by mx1.freebsd.org (Postfix) with ESMTP id 358BF8FC19;
	Thu,  8 Apr 2010 16:43:56 +0000 (UTC)
Received: from localhost (unknown [213.17.239.109])
	by smtp.semihalf.com (Postfix) with ESMTP id 3E2DEC427A;
	Thu,  8 Apr 2010 18:47:18 +0200 (CEST)
X-Virus-Scanned: by amavisd-new at semihalf.com
Received: from smtp.semihalf.com ([213.17.239.109])
	by localhost (smtp.semihalf.com [213.17.239.109]) (amavisd-new,
	port 10024)
	with ESMTP id r+9YueJnLaUA; Thu,  8 Apr 2010 18:47:17 +0200 (CEST)
Received: from [10.0.0.34] (cardhu.semihalf.com [213.17.239.108])
	by smtp.semihalf.com (Postfix) with ESMTPSA id 999B6C41E7;
	Thu,  8 Apr 2010 18:47:17 +0200 (CEST)
Mime-Version: 1.0 (Apple Message framework v1078)
Content-Type: text/plain; charset=us-ascii
From: Rafal Jaworowski <raj@semihalf.com>
In-Reply-To: <201004080857.53917.jhb@freebsd.org>
Date: Thu, 8 Apr 2010 18:43:54 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <5E88AD5A-D59E-4C29-9E98-632C70D02500@semihalf.com>
References: <201004071502.o37F2Rou064473@repoman.freebsd.org>
	<201004080857.53917.jhb@freebsd.org>
To: John Baldwin <jhb@freebsd.org>
X-Mailer: Apple Mail (2.1078)
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 176621 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2010 16:43:58 -0000


On 2010-04-08, at 14:57, John Baldwin wrote:

> On Wednesday 07 April 2010 11:02:27 am Rafal Jaworowski wrote:
>> http://p4web.freebsd.org/@@176621?ac=3D10
>>=20
>> Change 176621 by raj@raj_fdt on 2010/04/07 15:02:20
>>=20
>> 	Provide PCI-E defines.
>>=20
>> Affected files ...
>>=20
>> .. //depot/projects/fdt/sys/dev/pci/pcireg.h#3 edit
>>=20
>> Differences ...
>>=20
>> =3D=3D=3D=3D //depot/projects/fdt/sys/dev/pci/pcireg.h#3 (text+ko) =
=3D=3D=3D=3D
>>=20
>> @@ -218,6 +218,17 @@
>>=20
>> #define	PCIR_PCCARDIF_2	0x44
>>=20
>> +
>> +/* PCIE registers */
>> +#define PCIR_DCR	0x54
>> +#define PCIM_DCR_URR	0x0008
>> +#define PCIM_DCR_FER	0x0004
>> +#define PCIM_DCR_NFER	0x0002
>> +#define PCIR_DSR	0x56
>> +#define PCIR_LTSSM	0x404
>> +#define PCIM_LTSSM_L0	0x16
>=20
> Err, are you sure about these?  Generally the PCI-e registers are part =
of the=20
> PCI-e capability and are not a fixed offset.  Also, we already have =
constants=20
> for various PCI-e registers in pcireg.h like so:
>=20
> /* PCI Express definitions */

Thanks for pointing out. Let me look into improving and cleaning up this =
(primarily I was just moving existing defines which we had locally in =
mpc85xx PCI into a shared location without too deep thought).

Rafal