From owner-freebsd-wireless@FreeBSD.ORG  Thu Oct 31 02:10:01 2013
Return-Path: <owner-freebsd-wireless@FreeBSD.ORG>
Delivered-To: freebsd-wireless@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 8CD9F23B
 for <freebsd-wireless@smarthost.ysv.freebsd.org>;
 Thu, 31 Oct 2013 02:10:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7B2682504
 for <freebsd-wireless@smarthost.ysv.freebsd.org>;
 Thu, 31 Oct 2013 02:10:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r9V2A1ae083641
 for <freebsd-wireless@freefall.freebsd.org>; Thu, 31 Oct 2013 02:10:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r9V2A1aX083640;
 Thu, 31 Oct 2013 02:10:01 GMT (envelope-from gnats)
Date: Thu, 31 Oct 2013 02:10:01 GMT
Message-Id: <201310310210.r9V2A1aX083640@freefall.freebsd.org>
To: freebsd-wireless@FreeBSD.org
Cc: 
From: dfilter@FreeBSD.ORG (dfilter service)
Subject: Re: kern/183428: commit references a PR
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: "Discussions of 802.11 stack,
 tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-wireless>, 
 <mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
 <mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Oct 2013 02:10:01 -0000

The following reply was made to PR kern/183428; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/183428: commit references a PR
Date: Thu, 31 Oct 2013 02:05:01 +0000 (UTC)

 Author: adrian
 Date: Thu Oct 31 02:04:53 2013
 New Revision: 257412
 URL: http://svnweb.freebsd.org/changeset/base/257412
 
 Log:
   Don't treat the node as an 11n node if 11n rates are disabled.
   
   For now, the AMRR code only knows about _either_ MCS or non-MCS rates.
   It doesn't know how to downgrade (ie, doing 11b CCK rates if MCS0 isn't
   reliable.)
   
   PR:		kern/183428
 
 Modified:
   head/sys/net80211/ieee80211_amrr.c
 
 Modified: head/sys/net80211/ieee80211_amrr.c
 ==============================================================================
 --- head/sys/net80211/ieee80211_amrr.c	Thu Oct 31 02:03:30 2013	(r257411)
 +++ head/sys/net80211/ieee80211_amrr.c	Thu Oct 31 02:04:53 2013	(r257412)
 @@ -131,6 +131,12 @@ amrr_deinit(struct ieee80211vap *vap)
  	free(vap->iv_rs, M_80211_RATECTL);
  }
  
 +/*
 + * Return whether 11n rates are possible.
 + *
 + * Some 11n devices may return HT information but no HT rates.
 + * Thus, we shouldn't treat them as an 11n node.
 + */
  static int
  amrr_node_is_11n(struct ieee80211_node *ni)
  {
 @@ -139,6 +145,8 @@ amrr_node_is_11n(struct ieee80211_node *
  		return (0);
  	if (ni->ni_chan == IEEE80211_CHAN_ANYC)
  		return (0);
 +	if (IEEE80211_IS_CHAN_HT(ni->ni_chan) && ni->ni_htrates.rs_nrates == 0)
 +		return (0);
  	return (IEEE80211_IS_CHAN_HT(ni->ni_chan));
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"