From owner-svn-src-user@FreeBSD.ORG Tue Oct 23 19:31:30 2012 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EA06BAD1 for ; Tue, 23 Oct 2012 19:31:30 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 41D5E8FC14 for ; Tue, 23 Oct 2012 19:31:29 +0000 (UTC) Received: (qmail 88567 invoked from network); 23 Oct 2012 21:09:26 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 23 Oct 2012 21:09:26 -0000 Message-ID: <5086F086.6080000@freebsd.org> Date: Tue, 23 Oct 2012 21:31:18 +0200 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: Andre Oppermann Subject: Re: svn commit: r241966 - user/andre/tcp_workqueue/sys/net References: <201210231926.q9NJQnqu039908@svn.freebsd.org> In-Reply-To: <201210231926.q9NJQnqu039908@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: src-committers@freebsd.org, svn-src-user@freebsd.org X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2012 19:31:31 -0000 On 23.10.2012 21:26, Andre Oppermann wrote: > Author: andre > Date: Tue Oct 23 19:26:49 2012 > New Revision: 241966 > URL: http://svn.freebsd.org/changeset/base/241966 > > Log: > Extend PFIL hooks with explicit hook ordering and reinjecting of > packets into the chain after a particular hook. > > Add pfil_add_hook_order() taking a numerical value between 0-255 > to specify the relative position of this hook in the list of all > hooks. Lower numbers have higher ordering (ie. will run first). > Within a particular order value the last added will be the first > to run. Three fixed positions are defined: > PFIL_ORDER_FIRST 0 > PFIL_ORDER_DEFAULT 200 > PFIL_ORDER_LAST 255 > > Previously the order was non-deterministic and dependent on the > ordering of the add hook calls. The last added would always > become the first to run. > > Non-ordering aware pfil consumers using the pfil_add_hook() call > get PFIL_ORDER_DEFAULT assigned resulting in the previous ordering. > > The ordering is determined at hookup time by the pfil consumer > and no tool for later manual re-ordering is provided. Most well > known pfil consumers are expected to have a predetermined preferred > position in the order. A tool or sysctl reporting the order of > hooked pfil consumers will be provided later. > > Add pfil_run_inject() taking an opaque cookie value obtained with > pfil_get_cookie() after the hook is added. Processing of the hook > chain skips all hooks until after the one with the same cookie. > The cookie is valid as long as this hook remains hooked. If no > cookie is found processing is started with the first hook again. > If the cookie is invalid processing of all hooks is effectively > skipped. > > With this pfil hooks consumers can dequeue packets for further > processing and later re-inject them with the next hook. Besides the obvious ordering solution to the exiting pfil consumers my idea is to explore converting most of ether_input/output and IPsec processing to pfil hooks. This will need some further definitions for the default PFIL_ORDER points but that'll happen when there's some practical experimenting with running it. -- Andre