From owner-svn-src-all@freebsd.org Sat Mar 31 09:19:20 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 80F85F7177F; Sat, 31 Mar 2018 09:19:20 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 07F757A30B; Sat, 31 Mar 2018 09:19:19 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (mh0.gentlemail.de [78.138.80.135]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id w2V9JIvm012358; Sat, 31 Mar 2018 11:19:18 +0200 (CEST) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id 8C126F6E; Sat, 31 Mar 2018 11:19:18 +0200 (CEST) Message-ID: <5ABF5296.3050307@omnilan.de> Date: Sat, 31 Mar 2018 11:19:18 +0200 From: Harry Schmalzbauer Organization: OmniLAN User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; de-DE; rv:1.9.2.8) Gecko/20100906 Lightning/1.0b2 Thunderbird/3.1.2 MIME-Version: 1.0 To: Andriy Voskoboinyk CC: Bryan Drewery , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r324673 - head/sys/kern References: <201710162146.v9GLkB6t036842@repo.freebsd.org> <5305175e-e8d2-453d-9ba6-0281af1582a9@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Greylist: ACL 130 matched, not delayed by milter-greylist-4.2.7 (mx0.gentlemail.de [78.138.80.130]); Sat, 31 Mar 2018 11:19:18 +0200 (CEST) X-Milter: Spamilter (Reciever: mx0.gentlemail.de; Sender-ip: 78.138.80.135; Sender-helo: mh0.gentlemail.de; ) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Mar 2018 09:19:20 -0000 Bezüglich Andriy Voskoboinyk's Nachricht vom 17.10.2017 00:50 (localtime): > Tue, 17 Oct 2017 00:53:28 +0300 було написано Bryan Drewery > : > >> On 10/16/2017 2:46 PM, Andriy Voskoboinyk wrote: >>> Author: avos >>> Date: Mon Oct 16 21:46:11 2017 >>> New Revision: 324673 >>> URL: https://svnweb.freebsd.org/changeset/base/324673 >>> >>> Log: >>> mbuf(9): unbreak m_fragment() >> >> How was it broken > > Due to m_cat() usage reason (as described below); this part was > not changed since function creation in r119644. > >> and since when? > > No idea here - probably, it was partially working until m_cat() > improvement in r242256. > > P.S. Just checked with m_fragment(m, M_NOWAIT, -2) placed > right before ieee80211_mbuf_defrag() (from D4077) and > various m_len printf's before and after - it defragments > frames before this change and works as intended after it. > >> >>> >>> - Fix it by replacing m_cat() with m_prev->m_next = m_new >>> (m_cat() will try to append data - as a result, there will be no >>> fragmentation). >>> - Move some constants out of the loop. >>> >>> Was previously tested with D4077. >>> >>> Differential Revision: https://reviews.freebsd.org/D4090 Will r324673 be MFCd before 11.2? Thanks, -harry