From owner-freebsd-current@freebsd.org Thu Dec 13 13:33:38 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DB050132520F for ; Thu, 13 Dec 2018 13:33:37 +0000 (UTC) (envelope-from ctuffli@gmail.com) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E0A0288711 for ; Thu, 13 Dec 2018 13:33:36 +0000 (UTC) (envelope-from ctuffli@gmail.com) Received: by mail-pg1-f172.google.com with SMTP id g189so1078033pgc.5 for ; Thu, 13 Dec 2018 05:33:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dv7BwU0ok/pOtmFz6zjSdO7R5cN44LCDJrQ84Bamw48=; b=fP6apkzexdkiZRui3rAx5qAO7uhsm6u/nrcK/QrsddMcZArxAJJiu+M2J90SYE8Ql5 JQqMcv75N1lmXlkTZkxvo0R/vqeo2ve/nqz7e8N62TlrqzGj5D3LuKgrncsx1D/uF4u1 4UcpD5d+0GeNdGTR3HYxMb9lnz3kCy+Jz/qA/uiuR4zZDTG6yDgWmjenCqKck7Nt1ew1 No5WMzCJXLgbM32bM7qAQNXPjyoFtdInG6XF0fUZ9ru9YcIJkoMab72E6cWdgqKbo9eQ 4qpfkZaybAh/3exjLZRSTFmToQjmlTlJV/A265FPVagVmY6mpchLp75kZ8RURewUcxl4 4H9g== X-Gm-Message-State: AA+aEWbIaDet1Rntlk0u2FtOgRDP4IaY2M1gn8REuDni83dJjYM5ZQox 6Ve9L9LVm/14IRZHr/uxTBOs0eEp X-Google-Smtp-Source: AFSGD/VXtjuo0FqGY5Mu5c977L0u+Kys+mvfJYXI3WzP3SgRODP4qqIl6JEyvxOCcgqDLJK5Fsm8cQ== X-Received: by 2002:a62:46d0:: with SMTP id o77mr24356410pfi.172.1544708009430; Thu, 13 Dec 2018 05:33:29 -0800 (PST) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com. [209.85.215.171]) by smtp.gmail.com with ESMTPSA id s4sm2302745pgp.13.2018.12.13.05.33.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Dec 2018 05:33:28 -0800 (PST) Received: by mail-pg1-f171.google.com with SMTP id w6so1074499pgl.6 for ; Thu, 13 Dec 2018 05:33:28 -0800 (PST) X-Received: by 2002:a62:9f01:: with SMTP id g1mr24000243pfe.223.1544708008743; Thu, 13 Dec 2018 05:33:28 -0800 (PST) MIME-Version: 1.0 References: <015e28d3-3c6f-b5f3-b41a-5f6d367dddbb@yuripv.net> <9db60b9c-fea0-c5d6-5f8f-eae051c3f92d@yuripv.net> In-Reply-To: From: Chuck Tuffli Date: Thu, 13 Dec 2018 05:33:17 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: nda(4) does not work (reliably) in VMware Workstation To: yuripv@yuripv.net Cc: freebsd-current@freebsd.org X-Rspamd-Queue-Id: E0A0288711 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of ctuffli@gmail.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=ctuffli@gmail.com X-Spamd-Result: default: False [-2.92 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.992,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RCVD_COUNT_THREE(0.00)[4]; MIME_TRACE(0.00)[0:+,1:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[172.215.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.94)[-0.937,0]; RCVD_TLS_LAST(0.00)[]; FORGED_SENDER(0.30)[chuck@freebsd.org,ctuffli@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[172.215.85.209.rep.mailspike.net : 127.0.0.17]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[chuck@freebsd.org,ctuffli@gmail.com]; IP_SCORE(-0.98)[ipnet: 209.85.128.0/17(-3.54), asn: 15169(-1.30), country: US(-0.09)] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2018 13:33:38 -0000 On Sun, Dec 9, 2018 at 3:50 PM Chuck Tuffli wrote: > On Sun, Dec 9, 2018 at 3:43 PM Yuri Pankov wrote: > >> Chuck Tuffli wrote: >> > On Sat, Dec 8, 2018 at 12:28 PM Yuri Pankov > > > wrote: >> > >> > Hi, >> > >> > Running -HEAD in VMware Workstation 15.0.2 VM. Trying to use nda(4) >> > instead of nvd(4) shows the following list of errors, and eventually >> > panics: >> > >> > https://people.freebsd.org/~yuripv/nda1.png >> > https://people.freebsd.org/~yuripv/nda2.png >> > >> > nvd(4) works without issues in this VM. nda(4) works as well in >> VMware >> > ESXi VMs. Is this a problem with WS NVMe emulation? >> > >> > >> > Since I don't have access to ESXi, the attached is a speculative fix. If >> > it works, I'll clean this up a bit and get it committed. If not, please >> > post the output from: >> > nvmecontrol identtify nvme0 >> >> Thank you, it seems to help (was seeing the issue previously immediately >> after boot). BTW, the ESXi VM works fine with nda, it's only the >> Workstation that had the problem. Comparing `nvmecontrol identify` >> output from both, the only difference is (first is WS, second is ESXi): >> >> -Dataset Management Command: Not Supported >> +Dataset Management Command: Supported >> > > OK, that makes sense given the error message and the patch working. I'll > get this cleaned up and committed. Thanks for the report! > Committed r342046 to address this --chuck