From owner-freebsd-bugs Wed Feb 21 7:50:13 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id C268537B6A1 for ; Wed, 21 Feb 2001 07:50:01 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.1/8.11.1) id f1LFo1359050; Wed, 21 Feb 2001 07:50:01 -0800 (PST) (envelope-from gnats) Received: from mail.inka.de (quechua.inka.de [212.227.14.2]) by hub.freebsd.org (Postfix) with ESMTP id A05A837B65D for ; Wed, 21 Feb 2001 07:44:04 -0800 (PST) (envelope-from naddy@mips.inka.de) Received: from kemoauc.mips.inka.de (uucp@) by mail.inka.de with local-bsmtp id 14VbQx-0002qb-01; Wed, 21 Feb 2001 16:44:03 +0100 Received: (from naddy@localhost) by kemoauc.mips.inka.de (8.11.2/8.11.1) id f1LFg1N02718; Wed, 21 Feb 2001 16:42:01 +0100 (CET) (envelope-from naddy) Message-Id: <200102211542.f1LFg1N02718@kemoauc.mips.inka.de> Date: Wed, 21 Feb 2001 16:42:01 +0100 (CET) From: Christian Weisgerber Reply-To: naddy@mips.inka.de To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.113 Subject: kern/25254: devfs uses obsolete sa(4) device names Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org >Number: 25254 >Category: kern >Synopsis: devfs uses obsolete sa(4) device names >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Feb 21 07:50:01 PST 2001 >Closed-Date: >Last-Modified: >Originator: Christian Weisgerber >Release: FreeBSD 5.0-CURRENT alpha >Organization: >Environment: System: FreeBSD kemoauc.mips.inka.de 5.0-CURRENT FreeBSD 5.0-CURRENT #1: Wed Feb 21 15:14:11 CET 2001 naddy@kemoauc.mips.inka.de:/usr/src/sys/compile/KEMOAUC alpha >Description: devfs uses an obsolete set of SCSI tape device names: rsaN.ctl, rsaN*, nrsaN*, ersaN* Some time ago the tape device names were brought in line with the other devices and the 'r' (for "raw device") was stripped: saN.ctl, saN*, nsaN*, esaN* devfs should follow this convention as well. Also see the sa(4) man page. >How-To-Repeat: >Fix: --- sys/cam/scsi/scsi_sa.c.orig Wed Feb 21 14:52:38 2001 +++ sys/cam/scsi/scsi_sa.c Wed Feb 21 14:53:46 2001 @@ -1467,24 +1467,24 @@ softc->devs.ctl_dev = make_dev(&sa_cdevsw, SAMINOR(SA_CTLDEV, periph->unit_number, 0, SA_ATYPE_R), UID_ROOT, GID_OPERATOR, - 0660, "r%s%d.ctl", periph->periph_name, periph->unit_number); + 0660, "%s%d.ctl", periph->periph_name, periph->unit_number); for (i = 0; i < SA_NUM_MODES; i++) { softc->devs.mode_devs[i].r_dev = make_dev(&sa_cdevsw, SAMINOR(SA_NOT_CTLDEV, periph->unit_number, i, SA_ATYPE_R), - UID_ROOT, GID_OPERATOR, 0660, "r%s%d.%d", + UID_ROOT, GID_OPERATOR, 0660, "%s%d.%d", periph->periph_name, periph->unit_number, i); softc->devs.mode_devs[i].nr_dev = make_dev(&sa_cdevsw, SAMINOR(SA_NOT_CTLDEV, periph->unit_number, i, SA_ATYPE_NR), - UID_ROOT, GID_OPERATOR, 0660, "nr%s%d.%d", + UID_ROOT, GID_OPERATOR, 0660, "n%s%d.%d", periph->periph_name, periph->unit_number, i); softc->devs.mode_devs[i].er_dev = make_dev(&sa_cdevsw, SAMINOR(SA_NOT_CTLDEV, periph->unit_number, i, SA_ATYPE_ER), - UID_ROOT, GID_OPERATOR, 0660, "er%s%d.%d", + UID_ROOT, GID_OPERATOR, 0660, "e%s%d.%d", periph->periph_name, periph->unit_number, i); /* @@ -1492,11 +1492,11 @@ */ if (i == 0) { make_dev_alias(softc->devs.mode_devs[i].r_dev, - "r%s%d", periph->periph_name, periph->unit_number); + "%s%d", periph->periph_name, periph->unit_number); make_dev_alias(softc->devs.mode_devs[i].nr_dev, - "nr%s%d", periph->periph_name, periph->unit_number); + "n%s%d", periph->periph_name, periph->unit_number); make_dev_alias(softc->devs.mode_devs[i].er_dev, - "er%s%d", periph->periph_name, periph->unit_number); + "e%s%d", periph->periph_name, periph->unit_number); } } >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message