From owner-freebsd-gecko@freebsd.org Fri Jun 28 20:15:57 2019 Return-Path: Delivered-To: freebsd-gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A5FB15CA92D for ; Fri, 28 Jun 2019 20:15:57 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id B3CFD86B95 for ; Fri, 28 Jun 2019 20:15:56 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 7454915CA92C; Fri, 28 Jun 2019 20:15:56 +0000 (UTC) Delivered-To: gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5FA1315CA92B for ; Fri, 28 Jun 2019 20:15:56 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mouf.net", Issuer "mouf.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E63C886B94; Fri, 28 Jun 2019 20:15:55 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from lrrr.mouf.net (cpe-2606-A000-40C0-3500-14FF-229F-5AF7-9AAD.dyn6.twc.com [IPv6:2606:a000:40c0:3500:14ff:229f:5af7:9aad]) (authenticated bits=0) by mouf.net (8.14.9/8.14.9) with ESMTP id x5SKFlDw073380 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Fri, 28 Jun 2019 20:15:52 GMT (envelope-from swills@FreeBSD.org) Subject: Re: Firefox and GTK2 To: Jan Beich Cc: gecko@FreeBSD.org References: <7536c5cf-f8a0-fe5c-661f-b7909b9d57aa@FreeBSD.org> <491275b9-47ef-58b4-ab0c-bdaf1bed13b4@FreeBSD.org> From: Steve Wills Message-ID: <5d74ebf9-49cd-04bc-d6b5-aa156491f29f@FreeBSD.org> Date: Fri, 28 Jun 2019 16:15:40 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]); Fri, 28 Jun 2019 20:15:52 +0000 (UTC) X-Spam-Status: No, score=0.0 required=4.5 tests=none autolearn=unavailable autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mouf.net X-Virus-Scanned: clamav-milter 0.99.2 at mouf.net X-Virus-Status: Clean X-Rspamd-Queue-Id: E63C886B94 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.92 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.92)[-0.921,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-gecko@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gecko Rendering Engine issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jun 2019 20:15:57 -0000 Hi, On 6/28/19 3:03 PM, Jan Beich wrote: > Steve Wills writes: > [snip] > > www/firefox only directly loads libcanberra.so.0. Right, so we can have libcanberra use gtk2 or gtk3. > What actually depends > on -gtk3 slave? For one, x11-toolkits/gtk30 dropped it since 3.18.0. > > https://searchfox.org/mozilla-release/rev/be9f154873f1/widget/gtk/nsSound.cpp#159 > https://gitlab.gnome.org/GNOME/gtk/commit/7439a7efda25 It's not about gtk using libcanberra, it's about which gtk is used by libcanberra. > $ strings /usr/local/lib/libcanberra.so | fgrep gtk3 > $ strings /usr/local/lib/libcanberra-gtk.so | fgrep gtk3 > Those two files are from the package of libcanberra that depends on gtk2, so I wouldn't expect them to depend on gtk3. In libcanberra-gtk3, I see: $ ldd /usr/local/lib/libcanberra-gtk3.so.0.1.9 | grep gtk /usr/local/lib/libcanberra-gtk3.so.0.1.9: libgtk-3.so.0 => /usr/local/lib/libgtk-3.so.0 (0x800e00000) > GTK3 is still optional in www/seamonkey and not supported in www/palemoon. Maybe the libcanberra dep could be moved out of bsd.gecko.mk and into the ports? Steve