From nobody Tue Oct 21 15:06:11 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4crbGm0dJnz6CQ3L; Tue, 21 Oct 2025 15:06:24 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4crbGm04Qyz3M33; Tue, 21 Oct 2025 15:06:24 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761059184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SpwSHYx0W/yvqWr4I7zj+UwjUqbsEDqxwIW2SSkYZCI=; b=S4Mg1NtfEjD36ASzVeO4qoj4ncqq/Wg0D2EYr06F+Kes72Zs4+2foKjsV5nej7LBP96GuG vYGXF7M0+afOa73JoWkL272zkQ8iIXUouChsAhjSn58dhyAsSqkGPXvy1JIPKyL2fnCXhm 03764GuR4jo89QJ6IQHC1lbkcIeog+oD6QdIbySYSMb4mIJC/u1bIzcBnXByMVQF5gNozh utnG797QJr2SkqHt03VjbUR+B9/tzprNOVuw9OBYo5EmnLku+k0w6ek+hwIvkZtJaDCRws I4pSi2WFIxJml0owubehf7CO3uCjERBKuxjAW0Cpv9GQhUCDBe6HDsZvMzZ2Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761059184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SpwSHYx0W/yvqWr4I7zj+UwjUqbsEDqxwIW2SSkYZCI=; b=gJdb29Vb44SGUSGohTuO2bn1EIHX3efnb3V9tEfm7cVspBpCQ351PExDQA7yHV5f9CmVVi Cgb//MMKOk2ID3X5hHakkLeL08sImv83TOtHy0m1imQqZNLF4LEc8GP2IE92goMBJcv8g0 zDS/ySiQLLg6vp8pr7MdE3F2GC+67kujq0cJ11ITHVQBzXdcrl8g9lDX96BtxSTBWv/2jp tycbV38ehSu5cso6Rqrp1Hz90Pb5H4dN5/TgFzkPagOBtB+5nLMeZK77Rvr7Lzh7OaXMyi gaBuTtO7QeJx3A/JEfQdyd4f4IGFXpKmdgjfYj90X958KbLjdItZGKT6gR3JiQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1761059184; a=rsa-sha256; cv=none; b=VVF7kQm42BGPgD02CIrSwY5QdHUL48jhRTeP+Hnxk2fKDd+gnV3gQAHnkTljDKmvGMUjN9 emdXnxNhuwy5DBppQQsbuv52/L9+WYqpXtLJ7DRhi7bLqgCqW4LjfJyLmji4jTb8YMKLeC mGwRz4bA567f9Jbl8w0e2JoV6aO18miVOS//9xkCoCPpz5wxRt5jkC9YkTa1oK53Ivw7Cg e/f3voYAqfkZEjCuvjnptsUCtcAGO0ZVtsiNzI9J4mecsshZZ0oIrXJW6IWZKzcPIvD2Q2 6c3FFVZU21rRCTBWIkGEUcgYt1FpNXYiWKq+5eo8xuOzlm/mXbLN5fM5dJnIkg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E8" (verified OK)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4crbGl5fs0zNwf; Tue, 21 Oct 2025 15:06:23 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id A1C34A64805; Tue, 21 Oct 2025 15:06:05 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 7E9222D029E6; Tue, 21 Oct 2025 15:06:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id tSkBecJFQq0C; Tue, 21 Oct 2025 15:06:12 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id C811B2D029D8; Tue, 21 Oct 2025 15:06:11 +0000 (UTC) Date: Tue, 21 Oct 2025 15:06:11 +0000 (UTC) From: "Bjoern A. Zeeb" To: John Baldwin cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 885e8f272f75 - main - LinuxKPI: add skeleton pci_enable_wake() In-Reply-To: <0548e02e-3ee1-4459-95b7-ca3b720cbe96@FreeBSD.org> Message-ID: <72669827-7s38-oo59-6128-rns453r8n7r6@SerrOFQ.bet> References: <202510210753.59L7rC0f014520@gitrepo.freebsd.org> <0548e02e-3ee1-4459-95b7-ca3b720cbe96@FreeBSD.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Tue, 21 Oct 2025, John Baldwin wrote: > On 10/21/25 03:53, Bjoern A. Zeeb wrote: >> The branch main has been updated by bz: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=885e8f272f7515b0325974de72d18b73318eff07 >> >> commit 885e8f272f7515b0325974de72d18b73318eff07 >> Author: Bjoern A. Zeeb >> AuthorDate: 2025-10-17 20:38:11 +0000 >> Commit: Bjoern A. Zeeb >> CommitDate: 2025-10-21 07:49:39 +0000 >> >> LinuxKPI: add skeleton pci_enable_wake() >> Given we do not yet support "wake" bits in device there is little >> need >> doing it in PCI if we cannot check if we are supposed to do the >> operation in first place. Once we would implement this, we would need >> to also do the appropriate PCI (pme) checks before enabling >> (disabling) >> it. >> MFC after: 3 days >> Reviewed by: dumbbell >> Differential Revision: https://reviews.freebsd.org/D53208 > > FWIW, we have pci_enable_pme() that this probably maps to. Similarly, > pci_has_pm() > is a helper routine to see if a device supports power management. The > various NIC > drivers supporting WOL use these helper routines to manage PME. Thank you. LinuxKPI also has pci_pme_capable() already. I'll try to implement the lower device bits in LinuxKPI at some point (at least it's on my list) and this will hopefully help then to do the PCI bits quickly. /bz -- Bjoern A. Zeeb r15:7