From owner-cvs-all@FreeBSD.ORG Mon Jul 7 20:41:19 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 29C1C1065672; Mon, 7 Jul 2008 20:41:19 +0000 (UTC) (envelope-from emaste@freebsd.org) Received: from gw.sandvine.com (gw.sandvine.com [199.243.201.138]) by mx1.freebsd.org (Postfix) with ESMTP id D62B38FC15; Mon, 7 Jul 2008 20:41:18 +0000 (UTC) (envelope-from emaste@freebsd.org) Received: from labgw2.phaedrus.sandvine.com ([192.168.3.11]) by gw.sandvine.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 7 Jul 2008 16:29:15 -0400 Received: by labgw2.phaedrus.sandvine.com (Postfix, from userid 12627) id A407311652; Mon, 7 Jul 2008 16:29:15 -0400 (EDT) Date: Mon, 7 Jul 2008 16:29:15 -0400 From: Ed Maste To: Alfred Perlstein Message-ID: <20080707202915.GA17691@sandvine.com> References: <200807032326.m63NQCdW044654@repoman.freebsd.org> <20080707195209.GD95574@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080707195209.GD95574@elvis.mu.org> User-Agent: Mutt/1.4.2.1i X-OriginalArrivalTime: 07 Jul 2008 20:29:15.0899 (UTC) FILETIME=[2010CCB0:01C8E070] Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Ed Maste , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jul 2008 20:41:19 -0000 On Mon, Jul 07, 2008 at 12:52:09PM -0700, Alfred Perlstein wrote: > * Ed Maste [080703 16:26] wrote: > > emaste 2008-07-03 23:26:10 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern uipc_usrreq.c > > Log: > > SVN rev 180238 on 2008-07-03 23:26:10Z by emaste > > > > Use bcopy instead of strlcpy in uipc_bind and unp_connect, since > > soun->sun_path isn't a null-terminated string. As UNIX(4) states, "the > > terminating NUL is not part of the address." Since strlcpy has to return > > "the total length of the string [it] tried to create," it walks off the end > > of soun->sun_path looking for a \0. > > > > This reverts r105332. > > > > Reported by: Ryan Stone > > > > Revision Changes Path > > 1.215 +4 -2 src/sys/kern/uipc_usrreq.c > > This really deserves a comment at each invocation of bcopy in > order to prevent regressions by someone "fixing" it again. I thought about that but figured that a bcopy -> strlcpy conversion would be a lot less likely than the strncpy -> strlcpy change that happened here originally to introduce the bug. If it really seems like a candidate for someone to "fix" in the future I'll add a comment. - Ed