From owner-cvs-src@FreeBSD.ORG Wed Feb 28 02:32:30 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5F06816C939; Wed, 28 Feb 2007 02:32:30 +0000 (UTC) (envelope-from doconnor@gsoft.com.au) Received: from cain.gsoft.com.au (cain.gsoft.com.au [203.31.81.10]) by mx1.freebsd.org (Postfix) with ESMTP id DEEB113C48D; Wed, 28 Feb 2007 02:32:29 +0000 (UTC) (envelope-from doconnor@gsoft.com.au) Received: from inchoate.gsoft.com.au (ppp205-6.lns1.adl4.internode.on.net [203.122.205.6]) (authenticated bits=0) by cain.gsoft.com.au (8.13.8/8.13.8) with ESMTP id l1S2WLq9002125 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 28 Feb 2007 13:02:22 +1030 (CST) (envelope-from doconnor@gsoft.com.au) From: "Daniel O'Connor" To: cvs-all@freebsd.org Date: Wed, 28 Feb 2007 13:02:16 +1030 User-Agent: KMail/1.9.5 References: <200702272233.l1RMXocb004983@repoman.freebsd.org> In-Reply-To: <200702272233.l1RMXocb004983@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart9773721.Ip9sBIVfIQ"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200702281302.18223.doconnor@gsoft.com.au> X-Spam-Score: -1.762 () AWL,BAYES_00 X-Scanned-By: MIMEDefang 2.58 on 203.31.81.10 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Warner Losh Subject: Re: cvs commit: src/sys/dev/usb umass.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Feb 2007 02:32:30 -0000 --nextPart9773721.Ip9sBIVfIQ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wednesday 28 February 2007 09:03, Warner Losh wrote: > Create a new quirk READ_CAPACITY_OFFBY1 and add a quirk for the > SanDISK ImageMate that I have that suffers from this problem (the > SDDR-31). It intercepts the READ_CAPACITY response and adjusts it > from number of sectors to max sector for devices with this quirk. > > Reading the Linux source suggests that there are a host of > other devices with this issue, including iPods and some popular > cameras. I've not added quirks for them, since I don't have the > devices in front of me to test. Couldn't you automatically test for this? ie try and read the last sector. Obviously if there is a real error in the last sector you'd get a bogus res= ult=20 but I don't think that is likely to be very common :) =2D-=20 Daniel O'Connor software and network engineer for Genesis Software - http://www.gsoft.com.au "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C --nextPart9773721.Ip9sBIVfIQ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQBF5Omy5ZPcIHs/zowRAiUOAJ9R1wim3Q+3/EafipTfu/oZKAPMegCgoTfE Ttwmp/BkdH33Tnzk70rwoEE= =kvdu -----END PGP SIGNATURE----- --nextPart9773721.Ip9sBIVfIQ--