From owner-dev-commits-src-main@freebsd.org Thu May 20 02:33:38 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 08B9C6319BF; Thu, 20 May 2021 02:33:38 +0000 (UTC) (envelope-from zlei.huang@gmail.com) Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Flv1Y6GDqz3KK8; Thu, 20 May 2021 02:33:37 +0000 (UTC) (envelope-from zlei.huang@gmail.com) Received: by mail-pg1-x52e.google.com with SMTP id k15so10787255pgb.10; Wed, 19 May 2021 19:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Maq6XDlK7RAjJcWDlFIMOPGZmpiFePUlNQvqCC4YrjY=; b=AcfKfxGr/C8jFoprti1j4XaZQwcrbKHwmsSzCvI7cT5VVXZBXkd3romjPHhO47uwdb Y5mmsk63/pKFtPX2/riIrFkplLE19S1BsMSTzAn1xQma8mlCYfIJLX1vfyXtljIeUZlY bNYNrP/QG/zMIjMtU6fXgu1GZb5gcFGB3TdsuHPU5et2q2CAnwehG3JzYVorb1i6/u31 CMTB/p55q05yY55Yg7bI8pItTlLGdhr9BtIljCXRZLbBK5EF/SqbhScp95U1nBL/U1LE LsVL/IQWbwTFJuEPDPMDxlj0/wkzG2PdepJ/RkJZQUIcDX6YB4p3jQvUs5CcNpE3pQKR L+WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Maq6XDlK7RAjJcWDlFIMOPGZmpiFePUlNQvqCC4YrjY=; b=Rs+h8kQLEuP1xJdLzmFA/TswjoEXdQPM5nTD1XSBiy1O6Pyy6Oto1V60HjSTePWkbI gTmi3BfaWTbmO39C1h1L7vlOpm+uwP/p+n98tW4FvaIowVaCi8J7fyWVhs0DvQDE4rrw KxHeHsIyWTgBChyNJQzgoQT9XgKFZJmVw9vwun6apV0UlF0mJ2stQmRQNeaVvUXXI1BP /UV5kcQkSD/qFld+5DNHJyUADPPErYVsjMlWFQFSAYlIge/65gLjwJKMJzEasz+I1yEX jGJh0tjAcch8xPELq075Qr3xe0nIXZDHQfc0fPwh/FcQcCbGB6jBaIFOZIEoc5AoNZIN P08w== X-Gm-Message-State: AOAM533fTabNth7i16MjtICXLlodq5vX6LXtN2rXni3POIIVHlhqD0bF InndxsMPRrtHtqvJ9KGJ5eHMM7YFkr0Wu4Ak X-Google-Smtp-Source: ABdhPJwo1J1U80G3tMD0BUljzolbH2OSg1usU5dGdq/eOo/qWr3o/CKbmKtWW4rSSUBrSrlcVzzctA== X-Received: by 2002:a63:2686:: with SMTP id m128mr2188695pgm.406.1621478016422; Wed, 19 May 2021 19:33:36 -0700 (PDT) Received: from [192.168.10.252] ([112.66.183.133]) by smtp.gmail.com with ESMTPSA id u19sm543015pfn.158.2021.05.19.19.33.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 May 2021 19:33:35 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: git: 3d846e48227e - main - Do not forward datagrams originated by link-local addresses From: Zhenlei Huang In-Reply-To: <10b475c5-0100-2567-4e92-73b168b97e3f@marcuscom.com> Date: Thu, 20 May 2021 10:33:28 +0800 Cc: Lutz Donnerhacke , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: 7bit Message-Id: <1DD8ABB9-94B1-4B44-8003-25432A91D520@gmail.com> References: <202105182101.14IL1Gki054229@gitrepo.freebsd.org> <20210519055407.GA9715@belenus.iks-jena.de> <10b475c5-0100-2567-4e92-73b168b97e3f@marcuscom.com> To: Joe Clarke , rgrimes@freebsd.org X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4Flv1Y6GDqz3KK8 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 May 2021 02:33:38 -0000 Hi joe, > On May 19, 2021, at 9:42 PM, Joe Clarke wrote: > > On 5/19/21 01:54, Lutz Donnerhacke wrote: >> On Tue, May 18, 2021 at 07:51:38PM -0400, Joe Clarke wrote: >>> Just out of curiosity, why remove the RFC reference from the comment? >> >> May you please include the author of the change for such questions? >> >>>> commit 3d846e48227e2e78c1e7b35145f57353ffda56ba >>>> Author: Zhenlei Huang >>>> AuthorDate: 2021-05-18 20:51:37 +0000 >>>> Commit: Lutz Donnerhacke >>>> CommitDate: 2021-05-18 20:59:46 +0000 >>>> >>>> The current implement of ip_input() reject packets destined for >>>> 169.254.0.0/16, but not those original from 169.254.0.0/16 link-local >>>> addresses. >>>> >>>> Fix to fully respect RFC 3927 section 2.7. >>>> >>>> PR: 255388 >>>> Reviewed by: donner, rgrimes, karels >>>> MFC after: 1 month >>>> Differential Revision: https://reviews.freebsd.org/D29968 >> >> I did only commit this differential, but set a month for MFC, exactly to >> have to opportunity to fix such mistakes. >> > > IMHO, I'd like to see the RFC reference remain. I see rgrimes response > that the RFC's can change with errata and bis docs, but the anchor still > provides additional context that one can use to learn more about why > this code exists, and they can chase any future forward references. RFC's indeed change, and I think it is common in network stack. Then we need guidelines to better regulate these. CC rgrimes . > > It was there in the initial code, and the commit message saw fit to > reference it again. Removing it just seems like lost context. To track down the changes of the code, I'd personally prefer git-blame. There's still RFC reference in the git commit message, though it is not fully consistent with the comments in the diff. > > Joe > > -- > PGP Key : http://www.marcuscom.com/pgp.asc