From owner-soc-status@FreeBSD.ORG Mon Aug 24 20:31:10 2009 Return-Path: Delivered-To: soc-status@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B749B106568D; Mon, 24 Aug 2009 20:31:10 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 884948FC0C; Mon, 24 Aug 2009 20:31:10 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id E1AC146B06; Mon, 24 Aug 2009 16:31:09 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 229988A024; Mon, 24 Aug 2009 16:31:09 -0400 (EDT) From: John Baldwin To: Zhao Shuai Date: Mon, 24 Aug 2009 15:55:17 -0400 User-Agent: KMail/1.9.7 References: <8126ef5c0908220125u42463afbm3303413015c05107@mail.gmail.com> <20090822130445.GM1292@hoeg.nl> <8126ef5c0908230524g177f29d2qe836ad66c0c3f016@mail.gmail.com> In-Reply-To: <8126ef5c0908230524g177f29d2qe836ad66c0c3f016@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200908241555.17686.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 24 Aug 2009 16:31:09 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: soc-status Subject: Re: FIFO Optimization - final summary X-BeenThere: soc-status@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Summer of Code Status Reports and Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2009 20:31:10 -0000 On Sunday 23 August 2009 8:24:26 am Zhao Shuai wrote: > 2009/8/22 Ed Schouten > > > Hi, > > > > * Zhao Shuai wrote: > > > Hi All, > > > > > > This summer I worked on rewriting the FIFO(named pipe) subsystem. > > > The new FIFO system uses pipe implementation while previously > > > it is implemented as socket. > > > > > > The new FIFO code passes the official regression test and the following > > > bugs has been eliminated: PR 76525,PR 94772,PR 76144,PR 116770. > > > According to my performance test, the new FIFO system increases the > > > throughput by 30% comparing with the old one. > > > > > > I will continue to improve my code after GSoC and hope it can be merged > > > with the main tree. > > > > I'm too lazy to read the source, check out sources, etc. but the pipe > > and fifo code has now been merged, right? Just out of curiosity, how do > > these changes affect the kernel binary size? How many lines of code have > > been added/removed? > > > The original pipe code is moved into sys/kern/subr_pipe.c where we deal > with pipe internals. Most of the pipe code is kept untouched except some > changes to several function prototype. /sys/kern/sys_pipe.c is now just a > wrapper of pipe routines. > > The affect on the kernel binary size is negligible. Also, I've reviewed the changes and they were done in such a way that very minimal changes were made to the pipe code so history is well preserved. -- John Baldwin