From owner-svn-src-head@FreeBSD.ORG Mon Jul 8 22:13:26 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id B6595661; Mon, 8 Jul 2013 22:13:26 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x232.google.com (mail-pa0-x232.google.com [IPv6:2607:f8b0:400e:c03::232]) by mx1.freebsd.org (Postfix) with ESMTP id 81EE71C17; Mon, 8 Jul 2013 22:13:26 +0000 (UTC) Received: by mail-pa0-f50.google.com with SMTP id fb1so4851054pad.37 for ; Mon, 08 Jul 2013 15:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; bh=O69bBy/sGC6V+ZYcRC53MOnboBEIj9UQTas6y+EGmSs=; b=KDc4uy2mLO4KkX+22vspzoUg1iAI30hhtR3ZmIK8U407EGKzqDRoRpSQHQ6RwKShSD Fs7uZ9IEFeRhvyPeD6s3b1qs5kqRsuLOD02ZumUAuelCalqVul3oLraFg793XYMpRspd F7EsUukg8T/7zr3gDOuspUSV+N4Ceu4koJf9F2Cz3ZLJyERRiCfO7uk4GI5J/oejREgg F4ISIQtL5q12OSuHW2arqS2ApbEf2/M350slNKLJX6UN+UTXLx2lrWJ3xAIs6rjdy0om KVcwO12zGboG7SnI88JA/hRicQTcVhA4MNVkqibl/SsMtQzIDPuBcPZo73MBbARTAYKV g+lQ== X-Received: by 10.66.218.39 with SMTP id pd7mr25029921pac.148.1373321606262; Mon, 08 Jul 2013 15:13:26 -0700 (PDT) Received: from [192.168.242.58] (c-67-182-131-225.hsd1.wa.comcast.net. [67.182.131.225]) by mx.google.com with ESMTPSA id dj5sm24438421pbc.25.2013.07.08.15.13.24 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 08 Jul 2013 15:13:25 -0700 (PDT) Subject: Re: svn commit: r253048 - in head/sys/ofed: drivers/net/mlx4 include/linux Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Garrett Cooper In-Reply-To: <201307082125.r68LPDlY023493@svn.freebsd.org> Date: Mon, 8 Jul 2013 15:13:22 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <3FF894D3-ACDF-4796-A682-F9F9DD8C943D@gmail.com> References: <201307082125.r68LPDlY023493@svn.freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.1283) Cc: svn-src-head , svn-src-all , src-committers , shahark@mellanox.com X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jul 2013 22:13:26 -0000 On Jul 8, 2013, at 2:25 PM, John Baldwin wrote: > Author: jhb > Date: Mon Jul 8 21:25:12 2013 > New Revision: 253048 > URL: http://svnweb.freebsd.org/changeset/base/253048 >=20 > Log: > Allow mlx4 devices to switch from Ethernet to Infiniband (and vice = versa): > - Fix sysctl wrapper for sysfs attributes to properly handle new = string > values similar to sysctl_handle_string() (only copyin the user's > supplied length and nul-terminate the string). > - Don't check for a trailing newline when evaluating the desired = operating > mode of a mlx4 device. >=20 > PR: kern/179999 > Submitted by: Shahar Klein > MFC after: 1 week Was there an issue with the patch I submitted via = http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dkern/174213 (basically = solving the same problem, but only with the sysfs <-> sysctl(9) = handler)? I was of the impression that sysfs on Linux always added on = trailing newlines (but I could be wrong because I haven't used Linux at = a dev level for ages). Thanks!=