From owner-freebsd-net@FreeBSD.ORG  Thu Jul  7 20:10:03 2011
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 894241065676
	for <freebsd-net@hub.freebsd.org>; Thu,  7 Jul 2011 20:10:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 75CFC8FC22
	for <freebsd-net@hub.freebsd.org>; Thu,  7 Jul 2011 20:10:03 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p67KA3s1026555
	for <freebsd-net@freefall.freebsd.org>; Thu, 7 Jul 2011 20:10:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p67KA3k6026554;
	Thu, 7 Jul 2011 20:10:03 GMT (envelope-from gnats)
Date: Thu, 7 Jul 2011 20:10:03 GMT
Message-Id: <201107072010.p67KA3k6026554@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/156978: commit references a PR
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jul 2011 20:10:03 -0000

The following reply was made to PR kern/156978; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/156978: commit references a PR
Date: Thu,  7 Jul 2011 20:02:22 +0000 (UTC)

 Author: thompsa
 Date: Thu Jul  7 20:02:09 2011
 New Revision: 223846
 URL: http://svn.freebsd.org/changeset/base/223846
 
 Log:
   Grab the rlock before checking if our interface is enabled, it could be
   possible to hit a dead pointer when changing interfaces.
   
   PR:		kern/156978
   Submitted by:	Andrew Boyer
   MFC after:	1 week
 
 Modified:
   head/sys/net/if_lagg.c
 
 Modified: head/sys/net/if_lagg.c
 ==============================================================================
 --- head/sys/net/if_lagg.c	Thu Jul  7 18:07:03 2011	(r223845)
 +++ head/sys/net/if_lagg.c	Thu Jul  7 20:02:09 2011	(r223846)
 @@ -1221,14 +1221,15 @@ lagg_input(struct ifnet *ifp, struct mbu
  	struct lagg_softc *sc = lp->lp_softc;
  	struct ifnet *scifp = sc->sc_ifp;
  
 +	LAGG_RLOCK(sc);
  	if ((scifp->if_drv_flags & IFF_DRV_RUNNING) == 0 ||
  	    (lp->lp_flags & LAGG_PORT_DISABLED) ||
  	    sc->sc_proto == LAGG_PROTO_NONE) {
 +		LAGG_RUNLOCK(sc);
  		m_freem(m);
  		return (NULL);
  	}
  
 -	LAGG_RLOCK(sc);
  	ETHER_BPF_MTAP(scifp, m);
  
  	m = (*sc->sc_input)(sc, lp, m);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"