From owner-cvs-src@FreeBSD.ORG Tue Oct 5 22:37:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5004716A4CE; Tue, 5 Oct 2004 22:37:37 +0000 (GMT) Received: from caduceus.jf.intel.com (fmr06.intel.com [134.134.136.7]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0C8EB43D41; Tue, 5 Oct 2004 22:37:37 +0000 (GMT) (envelope-from robert.moore@intel.com) Received: from talaria.jf.intel.com (talaria.jf.intel.com [10.7.209.7]) major-outer.mc,v 1.15 2004/01/30 18:16:28 root Exp $) with ESMTP id i95Mabb8016651; Tue, 5 Oct 2004 22:36:37 GMT Received: from orsmsxvs040.jf.intel.com (orsmsxvs040.jf.intel.com [192.168.65.206]) major-inner.mc,v 1.11 2004/07/29 22:51:53 root Exp $) with SMTP id i95MSRWf003426; Tue, 5 Oct 2004 22:28:28 GMT Received: from orsmsx332.amr.corp.intel.com ([192.168.65.60]) M2004100515370206390 ; Tue, 05 Oct 2004 15:37:02 -0700 Received: from orsmsx403.amr.corp.intel.com ([192.168.65.209]) by orsmsx332.amr.corp.intel.com with Microsoft SMTPSVC(6.0.3790.0); Tue, 5 Oct 2004 15:37:01 -0700 X-MimeOLE: Produced By Microsoft Exchange V6.5.7226.0 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Date: Tue, 5 Oct 2004 15:37:00 -0700 Message-ID: <37F890616C995246BE76B3E6B2DBE0550237CFB3@orsmsx403.amr.corp.intel.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: cvs commit: src/usr.sbin/acpi/acpidump acpi.c acpidump.c acpidump.h thread-index: AcSrItMGvlvN6UmLTOisGtfGXfW8kgACNLSg From: "Moore, Robert" To: "Nate Lawson" , "John Baldwin" X-OriginalArrivalTime: 05 Oct 2004 22:37:01.0854 (UTC) FILETIME=[D4FD73E0:01C4AB2B] X-Scanned-By: MIMEDefang 2.31 (www . roaringpenguin . com / mimedefang) cc: Takanori Watanabe cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: RE: cvs commit: src/usr.sbin/acpi/acpidump acpi.c acpidump.c acpidump.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2004 22:37:37 -0000 I can add this next time I open up this interface. I think there are a couple of other requests outstanding on AcpiOsTableOverride(), perhaps in the SSDT area, I forget. > -----Original Message----- > From: Nate Lawson [mailto:nate@root.org] > Sent: Tuesday, October 05, 2004 2:31 PM > To: John Baldwin > Cc: Takanori Watanabe; src-committers@FreeBSD.org; cvs-src@FreeBSD.org; > cvs-all@FreeBSD.org > Subject: Re: cvs commit: src/usr.sbin/acpi/acpidump acpi.c acpidump.c > acpidump.h >=20 > Nate Lawson wrote: > > John Baldwin wrote: > >> I agree. It makes the user's lives a lot easier if they procedure > >> remains: > >> > >> - acpidump > foo.asl > >> - hack on foo.asl to fix it > >> - compile foo.asl to foo.dsdt > >> - load foo.dsdt in the loader > >> > >> and have it all just work. Actually, you know, we could make this > >> work on our own without requiring ACPI-CA to change. You just need to > >> hack AcpiOsTableOverride() in OsdTable.c to return a pointer to an > >> empty table for "SSDT" tables when the DSDT is overridden. In fact, I > >> think that is probably where this behavior decision really belongs. > > > > Good idea, I'll look into this. If feasible, I'll commit this and > > revert the acpidump change. >=20 > Ok, I've committed a tested version with this approach. The only > annoying part is that setting NewTable to NULL means "don't override > this one" so I had to supply an empty no-op table in place of the SSDT. > I backed out the acpidump changes. It would be better if ACPI-CA had > an option where returning AE_NO_TABLES or something would mean "ignore > this table completely". Right now, you can only override or leave the > default table. >=20 > -- > Nate