From owner-freebsd-stable@FreeBSD.ORG Wed Oct 1 21:27:58 2014 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 48004B88; Wed, 1 Oct 2014 21:27:58 +0000 (UTC) Received: from mail.ipfw.ru (mail.ipfw.ru [IPv6:2a01:4f8:120:6141::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0612DC80; Wed, 1 Oct 2014 21:27:57 +0000 (UTC) Received: from secured.by.ipfw.ru ([95.143.220.47] helo=[10.0.0.120]) by mail.ipfw.ru with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.82 (FreeBSD)) (envelope-from ) id 1XZNRv-0002ao-FF; Wed, 01 Oct 2014 21:12:23 +0400 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: 10.1-BETA2 possible kernel memory leak in routing table From: "Alexander V. Chernikov" In-Reply-To: <542C5529.9030800@FreeBSD.org> Date: Thu, 2 Oct 2014 01:27:47 +0400 Content-Transfer-Encoding: quoted-printable Message-Id: <7AB35136-89AA-48F2-8B0E-1BA3DCD4A6BA@ipfw.ru> References: <542AAA3C.1080803@ipfw.ru> <542AE376.6000003@FreeBSD.org> <542AFAE3.9030705@FreeBSD.org> <20141001135124.GM73266@glebius.int.ru> <542C20D7.3070606@sentex.net> <20141001171646.GQ73266@glebius.int.ru> <542C5529.9030800@FreeBSD.org> To: "Alexander V. Chernikov" X-Mailer: Apple Mail (2.1878.6) Cc: Rumen Telbizov , "freebsd-stable@freebsd.org" , Gleb Smirnoff , brian@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Oct 2014 21:27:58 -0000 On 01 Oct 2014, at 23:25, Alexander V. Chernikov = wrote: > On 01.10.2014 22:49, Rumen Telbizov wrote: >> Submitted PR with details at = https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D194078 >>=20 >>=20 >> On Wed, Oct 1, 2014 at 10:16 AM, Gleb Smirnoff > wrote: >>=20 >> On Wed, Oct 01, 2014 at 11:42:15AM -0400, Mike Tancsa wrote: >> M> On 10/1/2014 9:51 AM, Gleb Smirnoff wrote: >> M> > On Tue, Sep 30, 2014 at 04:56:00PM -0700, Rumen Telbizov = wrote: >> M> > R> Brian Somers and I are currently looking into the source >> of PF in latest >> M> > R> 10-STABLE and trying to figure out what is going on. We >> were able to >> M> > R> replicate this problem on a 11-CURRENT (Sep 12th) machine >> as well. A simple >> M> > R> PF ruleset with 1 rule and 1 table. Every few reloads of >> the firewall >> M> > R> and vmstat >> M> > R> -m | grep routetbl shows increased memory usage. >> M> > >> M> > I plugged the easy leak, but there is also a hard one. >> Actually, the >> M> > entire pf_table.c needs a good shake. Right now I am out of >> time for this. >> M> >> M> Is that easy fix >> M> >> M> >> = http://lists.freebsd.org/pipermail/svn-src-head/2014-October/063178.html >>=20 >> Yes, it seems the leak slowed down. >>=20 >> M> Also, is there any work around to this ? I tried a simple set >> of pf >> M> rules with no tables, hoping that was the cause of it, but >> memory grows >> M> with each pf reload. >>=20 >> No workaround available. Can you please file a PR for that? Once I >> have >> time, I will work on this. >>=20 > Remaining leak is not related to pf. > It happens due to rn_detachhead() not properly freeing items inside it = masks tree. > I'll try to fix this soon. I=92ve committed fix in r272385. Can you try it and check if this helps? >>=20 >>=20 >> -- >> Totus tuus, Glebius. >>=20 >>=20 >>=20 >>=20 >> --=20 >> Rumen Telbizov >> Unix Systems Administrator >=20 > _______________________________________________ > freebsd-stable@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-stable > To unsubscribe, send any mail to = "freebsd-stable-unsubscribe@freebsd.org" >=20