Date: Sun, 15 Jan 2012 18:28:09 -0500 From: John Baldwin <jhb@FreeBSD.org> To: Eitan Adler <eadler@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r230125 - head/sys/kern Message-ID: <4F136109.9050004@FreeBSD.org> In-Reply-To: <201201150709.q0F79Iif067938@svn.freebsd.org> References: <201201150709.q0F79Iif067938@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1/15/12 2:09 AM, Eitan Adler wrote: > Author: eadler (ports committer) > Date: Sun Jan 15 07:09:18 2012 > New Revision: 230125 > URL: http://svn.freebsd.org/changeset/base/230125 > > Log: > - Fix undefined behavior when device_get_name is null > - Make error message more informative The in-kernel printf(9) always prints "(null)" for %s when the pointer is NULL, so that wasn't undefined behavior. Printing out the driver name is a useful change, but the "(unknown)" bits are just noise as it isn't clear that "(unknown)" is substantially better than "(null)". -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F136109.9050004>